@jywarren Can I work on this?

Hi @roshniRam are you still interested in this at all?

I think we may be able to remove the tooltip attribute here and just build in the Bootstrap-style tooltips into the span:

It would require calling the tooltip bootstrap javascript function here, too:

https://getbootstrap.com/docs/3.3/javascript/#tooltips

This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting or reposting it as a first-timers-only issue, and then ping @publiclab/reviewers to get it labelled. Or, if this is not your first time, try to solve it yourself!

Ah just saw this one after all my tooltip updates! I will open an issue for this soon to get one done and the workflow down then an FTO for the rest. Will use the nice tooltips from material kit pro to match the icons :)

Uploaded to GCI dashboard.

published

could i try this issue?

@neelesh17 yes would love your help on this! The one catch is that we should do it without pulling in an external library, so you you'll have to make them from scratch. (I find that more fun anyways) 👍

hey @sashadev-sky, i am still unclear about what is it we are trying to achive in this issue.Would you help me out please.

@neelesh17 Currently the tooltips look like this:

And we were thinking to make them look nicer, closer to this: (this screenshot is from a toolbar in a different PL project, only the tooltip is relevant)

but also open to other designs if theres a specific one you like and want to implement

Hi @roshniRam are you still interested in this at all?

I think we may be able to remove the tooltip attribute here and just build in the Bootstrap-style tooltips into the span:

Leaflet.DistortableImage/src/edit/DistortableImage.EditToolbar.js

Lines 14 to 16 in 90c9777

	html: '<span class="fa fa-adjust"></span>',
	tooltip: 'Toggle Image Transparency',
	title: 'Toggle Image Transparency'

It would require calling the tooltip bootstrap javascript function here, too:

https://getbootstrap.com/docs/3.3/javascript/#tooltips

Hi @jywarren , @sashadev-sky , @TildaDares I think the file "DistortableImage.EditToolbar.js" inside edit folder isn't their anymore. Please correct me if I'm wrong. Thanks!!

Hi, good point! Do you think the code lives here now?