Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polygon to searched country/state (FTO) #1250

Open
5 tasks
vanithaak opened this issue Oct 27, 2022 · 9 comments · May be fixed by #1258
Open
5 tasks

Add polygon to searched country/state (FTO) #1250

vanithaak opened this issue Oct 27, 2022 · 9 comments · May be fixed by #1258

Comments

@vanithaak
Copy link
Contributor

vanithaak commented Oct 27, 2022

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from underrepresented groups in free and open-source software!

We know that the process of creating a pull request is one of the biggest barriers for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Claim the issue by commenting. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
💡 Learn how to claim 🙋

Claiming an issue

Unless the issue is marked as reserved for someone, you can just say "I'd like to try this!" and then you've claimed it - no need to wait for someone to assign it to you. Just be sure you link your pull request (PR) to this issue so we can see where your solution is.

And open one early if possible - even before you've completed it with additional commits - and others can help you figure out any issues you may face.

  • 📝 Update the file index.js in the Leaflet.DistortableImage repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

-15L.Control.geocoder().addTo(map);
+15var geocoder = L.Control.geocoder({
+16  defaultMarkGeocode: true
+17})
+18  .on('markgeocode', function(e) {
+19   var bbox = e.geocode.bbox;
+20   var poly = L.polygon([
+21     bbox.getSouthEast(),
+22     bbox.getNorthEast(),
+23     bbox.getNorthWest(),
+24     bbox.getSouthWest()
+25    ]).addTo(map);
+26   map.fitBounds(poly.getBounds());
+27  })
+28  .addTo(map);

THIS IS HOW THE MAP SHOULD LOOK, WHEN YOU SEARCH COUNTRY/STATE etc
image

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@welcome
Copy link

welcome bot commented Oct 27, 2022

Thanks for opening your first issue here! This space is protected by our Code of Conduct - and we're here to help.
Please follow the issue template to help us help you 👍🎉😄
If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸
You can make a gif too!
Do join our Gitter channel for some brainstorming discussions.

@vanithaak
Copy link
Contributor Author

@TildaDares

@liryyy
Copy link

liryyy commented Oct 29, 2022

Hi, @TildaDares , can I please make a contribution on this issue?

@liryyy liryyy linked a pull request Oct 29, 2022 that will close this issue
5 tasks
@lata-11
Copy link

lata-11 commented Jan 18, 2023

Hey! is this issue still open? If yes, I would like to work on this. Please assign.

@7malikk
Copy link
Collaborator

7malikk commented Jan 19, 2023

@lata-11 there is a PR opened for this issue, try and contact @liryyy if they are still interested and you both can collaborate in completing the solution as I noticed it requires a few more touches.

If you do not get a response from @liryyy, feel free to complete the solution. Thank you 🎉

@lata-11
Copy link

lata-11 commented Jan 20, 2023

Hey @liryyy are you still on it?

@proy03
Copy link

proy03 commented Feb 5, 2023

hey @7malikk, I was enthusiastic new comer to open source and was willing to contribute. I would love to work on this issue.

@proy03
Copy link

proy03 commented Feb 5, 2023

@vanithaak Is this still open?

@7malikk
Copy link
Collaborator

7malikk commented Feb 6, 2023

Hello @proy03, thank you for your interest in Public Lab as being your first step in open source.
Concerning this issue, I'd advise you to ask @liryyy if they are interested in completing the PR as seen here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants