changing from getElementById to a querySelector #1174

leumasxxx · 2022-10-16T17:20:26Z

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from underrepresented groups in free and open-source software!

We know that the process of creating a pull request is one of the biggest barriers for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

🙋 Claim this issue: Claim the issue by commenting. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

💡 Learn how to claim 🙋

Claiming an issue

Unless the issue is marked as reserved for someone, you can just say "I'd like to try this!" and then you've claimed it - no need to wait for someone to assign it to you. Just be sure you link your pull request (PR) to this issue so we can see where your solution is.

And open one early if possible - even before you've completed it with additional commits - and others can help you figure out any issues you may face.

📝 Update the file pixelorigin.html in the Leaflet.DistortableImage repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

-90  document.getElementById('info').innerHTML =
+90 document.querySelector('#info').innerHTML =
$DIFF

💾 Commit your changes
🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.

🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

The text was updated successfully, but these errors were encountered:

welcome · 2022-10-16T17:20:28Z

Thanks for opening your first issue here! This space is protected by our Code of Conduct - and we're here to help.
Please follow the issue template to help us help you 👍🎉😄
If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸
You can make a gif too!
Do join our Gitter channel for some brainstorming discussions.

leumasxxx · 2022-10-16T17:23:17Z

@TildaDares @cesswairimu I created this FTO for first timers who are still looking for an issue to resolve and I'd be delighted if it can be assigned to someone

TildaDares · 2022-10-16T18:14:01Z

Hi @leumasxxx, thank you for opening this issue for first-timers. Please take a look at this issue to know the expected format of an FTO #1135. Thank you!

leumasxxx · 2022-10-16T21:26:28Z

@TildaDares ive seen the format and I've made the necessary adjustments

7malikk · 2022-10-16T22:15:28Z

@leumasxxx Nice work! Keep them coming 👍🏾

liliyao2022 · 2022-10-16T23:25:38Z

Hi, I'd like to try.

liliyao2022 · 2022-10-16T23:39:00Z

hi @leumasxxx, the file link is wrong. Please add the correct link. Thanks!

leumasxxx · 2022-10-17T02:59:08Z

hi @leumasxxx, the file link is wrong. Please add the correct link. @liliyao2022 I do not understand what you mean by incorrect link can you rephrase please?

leumasxxx · 2022-10-17T03:00:16Z

@leumasxxx Nice work! Keep them coming 👍🏾

@7malikk thank you very much

TildaDares · 2022-10-17T08:03:02Z

Hi @leumasxxx, please add the correct file link in the issue description. Thank you!

TildaDares · 2022-10-17T08:07:17Z

Hi @liliyao2022, an issue was reserved for you here #1146

leumasxxx · 2022-10-17T08:18:46Z

Hi @leumasxxx, please add the correct file link in the issue description. Thank you!
Okay im on it

leumasxxx · 2022-10-17T16:24:10Z

@TildaDares after going through the issue I created, I noticed my faults in it but now I think I've made the necessary corrections and it's ready to be assigned.

TildaDares · 2022-10-17T17:29:36Z

Amazing work @leumasxxx. Thank you!

TildaDares · 2022-10-17T17:29:53Z

Reserved for @iLynette for 24 hours!

iLynette · 2022-10-17T17:37:19Z

On it @TildaDares Thank you.

TildaDares · 2022-10-25T06:14:00Z

Hi @iLynette, do you need help with this? Please reach out if you do. Thanks!

jssol · 2022-10-26T00:39:14Z

Hello @iLynette @TildaDares, I would love to help out on this issue.

TildaDares · 2022-11-02T06:29:20Z

Reserved for @Jolah1 for 24 hours!

Jolah1 · 2022-11-03T06:56:13Z

@TildaDares working on it now,
thank you.

Aarav238 · 2022-12-03T06:31:56Z

Hey, I would like to work on this.

Aarav238 · 2022-12-03T06:32:26Z

I'd like to try this!

Nehemiah60 · 2022-12-15T10:40:55Z

Hello, I will like to try this issue

7malikk · 2022-12-15T13:09:12Z

@jywarren @TildaDares @cesswairimu this looks like it's not being worked on could it be assigned to @Nehemiah60 or anyone in line?

Nehemiah60 · 2022-12-15T15:20:32Z

Yes please

TildaDares · 2022-12-15T15:41:35Z

Hi @Nehemiah60, please go ahead. Thanks @7malikk!

Nehemiah60 · 2022-12-15T18:18:14Z

Hello, would you like to review? I made a commit. Thanks.

7malikk · 2022-12-15T18:26:52Z

@Nehemiah60 Make a PR and ping me or any of the mentors, we'd be glad to review and merge.
Thank you!

Nehemiah60 · 2022-12-15T18:49:37Z

Okay, based on the instructions provided, I could not edit the file once I clicked it because I was not on the branch. I had to open it in github.dev. made the changes and pushed them to the patch-1 branch. I am stuck in making a PR.

7malikk · 2022-12-15T19:00:12Z

Hey @Nehemiah60 I believe I just saw your PR #1298
Guess you already figured it out.

Nehemiah60 · 2022-12-15T19:03:11Z

Yeah, I did

AliJafriETH · 2022-12-17T11:41:10Z

Hey @7malikk, i would love to work on this issue, is it still open?

7malikk · 2022-12-19T09:03:40Z

Hello @AliJafriETH, Sorry this issue is still open, it has already been worked on.
You could be on the lookout for new good first-timer-issues.
Cheers!

AliJafriETH · 2022-12-19T10:39:41Z

Sure @7malikk , thank you man!

7malikk · 2022-12-19T10:40:34Z

Sure @7malikk , thank you man!

Anytime @AliJafriETH

Sreejith2 · 2023-01-21T21:09:20Z

i would like to fix this issue.

iulianPreuteasa · 2023-01-23T11:25:38Z

Hi everyone,

I would like to give a go as well,

Thanks

pankajkrbansal · 2023-01-29T10:08:07Z

I'd like to try this!

shubham-singh-748 · 2023-02-28T17:09:45Z

just want to know, is this issue still open, if yes then please assign me & i am ready to work on that.....

hound77 · 2023-03-03T19:56:31Z

@TildaDares I want to work on this issue

hound77 · 2023-03-03T20:10:23Z

@TildaDares I want to contribute can you please help me to get a good first issue ticket to start with.

leumasxxx added the fto-candidate label Oct 16, 2022

leumasxxx closed this as completed Oct 17, 2022

leumasxxx changed the title ~~Typographical error(for first timers)/Spelling error~~ changing from getElementById to a querySelector Oct 17, 2022

leumasxxx reopened this Oct 17, 2022

TildaDares added first-timers-only and removed fto-candidate labels Oct 17, 2022

TildaDares mentioned this issue Nov 2, 2022

[Closed - sorry!] ✨ First-Timers Only Issues! 🌈 Make & Request Your Issue! publiclab/plots2#11105

Open

67 tasks

cesswairimu mentioned this issue Dec 2, 2022

Replace var with let/const #1160

Closed

5 tasks

Aarav238 mentioned this issue Dec 3, 2022

Change 'getElementById' to 'querySelector'. #1285

Closed

5 tasks

7malikk mentioned this issue Dec 6, 2022

Added search location feature to archive.html #1286

Merged

5 tasks

7malikk mentioned this issue Dec 15, 2022

changed byElementID to querySelector#1298 #1298

Closed

5 tasks

iulianPreuteasa mentioned this issue Jan 23, 2023

changing from getElementById to querySelector on #1174 issue #1338

Merged

5 tasks

hound77 mentioned this issue Mar 3, 2023

changing from getElementById to a querySelector Updated pixelorigin.js #1376

Open

5 tasks

cesswairimu closed this as completed in #1338 Mar 11, 2023

changing from getElementById to a querySelector #1174

changing from getElementById to a querySelector #1174

Comments

leumasxxx commented Oct 16, 2022 • edited by TildaDares

🤔 What you will need to know.

📋 Step by Step

Claiming an issue

🤔❓ Questions?

Is someone else already working on this?

welcome bot commented Oct 16, 2022

leumasxxx commented Oct 16, 2022

TildaDares commented Oct 16, 2022

leumasxxx commented Oct 16, 2022

7malikk commented Oct 16, 2022

liliyao2022 commented Oct 16, 2022

liliyao2022 commented Oct 16, 2022

leumasxxx commented Oct 17, 2022

leumasxxx commented Oct 17, 2022

TildaDares commented Oct 17, 2022

TildaDares commented Oct 17, 2022

leumasxxx commented Oct 17, 2022

leumasxxx commented Oct 17, 2022

TildaDares commented Oct 17, 2022

TildaDares commented Oct 17, 2022

iLynette commented Oct 17, 2022

TildaDares commented Oct 25, 2022

jssol commented Oct 26, 2022

TildaDares commented Nov 2, 2022

Jolah1 commented Nov 3, 2022

Aarav238 commented Dec 3, 2022

Aarav238 commented Dec 3, 2022

Nehemiah60 commented Dec 15, 2022

7malikk commented Dec 15, 2022 • edited

Nehemiah60 commented Dec 15, 2022

TildaDares commented Dec 15, 2022

Nehemiah60 commented Dec 15, 2022

7malikk commented Dec 15, 2022

Nehemiah60 commented Dec 15, 2022

7malikk commented Dec 15, 2022

Nehemiah60 commented Dec 15, 2022

AliJafriETH commented Dec 17, 2022

7malikk commented Dec 19, 2022

AliJafriETH commented Dec 19, 2022

7malikk commented Dec 19, 2022

Sreejith2 commented Jan 21, 2023

iulianPreuteasa commented Jan 23, 2023 • edited

pankajkrbansal commented Jan 29, 2023

shubham-singh-748 commented Feb 28, 2023

hound77 commented Mar 3, 2023

hound77 commented Mar 3, 2023

leumasxxx commented Oct 16, 2022 •

edited by TildaDares

7malikk commented Dec 15, 2022 •

edited

iulianPreuteasa commented Jan 23, 2023 •

edited