Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: arrow-key placement #338

Open
jywarren opened this issue Jul 10, 2019 · 3 comments · May be fixed by #534
Open

Feature: arrow-key placement #338

jywarren opened this issue Jul 10, 2019 · 3 comments · May be fixed by #534

Comments

@jywarren
Copy link
Member

jywarren commented Jul 10, 2019

Please note we are preparing to participate in Google Code-in, and have reserved this issue for GCI participants - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.

This might conflict with the "pan the map" usage of arrow keys, but:

Sometimes it is hard to move the photo to the EXACT point on which you want it. If you could click the photo and use arrow keys to move the selected photo this could help with the accuracy. At the moment pressing the arrow keys moves the whole map. This is also a good feature. Keep this but add a way of clicking on the photo which selects it so you can then use arrow keys to move accurately.

From https://publiclab.org/notes/molangmuir10/07-02-2019/mapknitter-ui-evaluation-2-mapping-nottingham-s-urban-greening#As+well+as+the+screen+recording+here+are+some+general+points+from+using+mapknitter...

However, maybe arrow keys could be used for moving an image when an image is selected, but otherwise for panning the map.

💬 Get help

If you need any help - here are some options:

@sashadev-sky sashadev-sky changed the title Future feature: arrow-key placement Future: arrow-key placement Jan 13, 2020
@sashadev-sky sashadev-sky changed the title Future: arrow-key placement Feature: arrow-key placement Jan 13, 2020
@sashadev-sky
Copy link
Member

Uploaded to GCI dashboard

@SidharthBansal
Copy link
Member

Published

@anthony-zhou
Copy link
Member

Does anyone know where the arrow key event listeners are handled? I'm planning to go there and check if the image is selected to determine whether to move the image or the map.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants