Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve linting errors #291

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Resolve linting errors #291

wants to merge 6 commits into from

Conversation

ovpv
Copy link

@ovpv ovpv commented Nov 14, 2019

Fixes #274

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@welcome
Copy link

welcome bot commented Nov 14, 2019

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@ovpv ovpv changed the title WIP: Resolve linting errors Resolve linting errors Nov 14, 2019
@Rishabh570
Copy link
Collaborator

@ovpv Are you still working on it? This PR contains some conflicts...

@ovpv
Copy link
Author

ovpv commented May 13, 2023

Hi There, I have updated the lint fixes. Please review and approve

PS: the commit showing up with a different name because i forgot to switch my commit profile. Not sure how to revert that to my personal one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve linting errors
3 participants