Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing 'Fork me on Github' ribbon for mobile devices #444

Open
waridrox opened this issue Mar 22, 2021 · 4 comments · May be fixed by #445
Open

Removing 'Fork me on Github' ribbon for mobile devices #444

waridrox opened this issue Mar 22, 2021 · 4 comments · May be fixed by #445

Comments

@waridrox
Copy link
Member

Please describe the problem (or idea)

For mobile screens that have such small screen real estate to begin with, the Fork me on Github ribbon takes almost 30% of the screen size and continues till the end of the page.

Before the fix
Screenshot 2021-03-22 at 10 52 03 PM

After the fix
Screenshot 2021-03-22 at 10 55 20 PM

If the ribbon is removed, this would utilise the wasted space and make the font bigger that would be easier on the eyes :D

Please show us where to look

https://code.publiclab.org/

@waridrox waridrox linked a pull request Mar 22, 2021 that will close this issue
5 tasks
@govindgoel
Copy link
Member

@waridrox That is there for a reason to easily navigate to the project.

@waridrox
Copy link
Member Author

waridrox commented Mar 27, 2021

Agreed, but in mobile view, there's already a github logo down at the bottom which directs to the codebase. And someone navigating on mobile device would rarely open the github repo to see the codebase, so I think it would make sense to hide it for small screen resolutions...🤔

Screenshot 2021-03-27 at 12 40 46 PM

In addition to this, this makes the scroll to top button position weird at 2/3rd screen width which should instead be at the edge of the screen if the ribbon is removed.

@govindgoel
Copy link
Member

For only a small screen size, we can think of that.

@Anshul-target
Copy link

Could you assign this project to me .I am very sure I can do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants