Removing unused code #68

IshaGupta18 · 2019-07-22T12:44:54Z

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

Problem

Some of the code which was previously written is not required anymore.

📋Solution

Remove
<button type="button" class="btn btn-success" id=' + this.gsheetId + '> Export as Google </button><div class="g-signin2" data-onsuccess=' + this.onSignIn + '></div> at line

simple-data-grapher/src/View.js

Line 347 in fa222a4

    
           this.element.innerHTML = '<div class="body_container"><div class="main_heading_container"><h2 class="main_heading"> Simple Data Grapher</h2><p class="sub_heading">Plot and Export Graphs with CSV data</p></div><div class="heading_container"><ul class="headings"><li class="item-1">Upload CSV Data</li><li class="item-2">Select Columns & Graph Type</li><li class="item-3">Plotted Graph & Export Options</li></ul></div><div id=' + this.carousalId + ' class="carousel ' + this.carousalClass + ' slide" data-ride="carousel"><div class="indicators"><ol class="carousel-indicators"> <li data-target="#' + this.carousalId + '" data-slide-to="0" class="active" id="up"></li> <li data-target="#' + this.carousalId + '" data-slide-to="1"></li> <li data-target="#' + this.carousalId + '" data-slide-to="2"></li></ol></div><div class="carousel-inner"><div class="carousel-item active"><div class="main_container"><div class="container_drag_drop"><span class="btn btn-outline-primary btn-file input_box"><p class="drag_drop_heading" id=' + this.dragDropHeadingId + '> <u> Choose a csv file </u> or drag & drop it here </p><input type="file" class="csv_file" id=' + this.elementId + "_csv_file" + ' accept=".csv"></span></div><h6 class="or"><span>OR</span></h6><div class="container_remote_link"><input type="text" class="remote_file text_field" placeholder="url of remote file" id=' + this.elementId + "_remote_file" + ' ></div><h6 class="or"><span>OR</span></h6><div class="container_csv_string"><textarea class="csv_string text_field" id=' + this.elementId + "_csv_string" + ' placeholder="Paste a CSV string here" ></textarea></div><h6 class="or"><span>OR</span></h6><div class="container_google_sheet"><input type="text" class="google_sheet text_field" id=' + this.elementId + "_google_sheet" + ' placeholder="Link of published Google Sheet" ></div><div class="upload_button"><button type="button" class="btn btn-primary" id=' + this.uploadButtonId + ' >Upload CSV</button></div></div></div><div class="carousel-item tables"><div class="button_container"><div><input type="checkbox" name=' + this.xyToggleName + ' checked data-toggle="toggle" class="xytoggle" data-width="150" data-onstyle="success" data-offstyle="warning" data-height="40"></div><div class="plot_button"><button type="button" class="btn btn-primary" id=' + this.plotGraphId + ' >Plot Graph</button></div></div><div class="table_container"><div id=' + this.tableXParentId + ' ><table id=' + this.tableXId + ' class="table"></table></div><div id=' + this.tableYParentId + ' class="hidden"><table id=' + this.tableYId + ' class="table"></table></div><div><table id=' + this.graphMenuId + ' class="table table-dark"></table></div></div></div><div class="carousel-item graph"><div class="feature_buttons"><button type="button" class="btn btn-primary" id=' + this.addGraphButtonId + '> Add Graph</button><button type="button" class="btn btn-success" id=' + this.createSpreadsheetButtonId + '> Create Spreadsheet<i class="fa fa-plus" aria-hidden="true"></i></button><button type="button" class="btn btn-success" id=' + this.gsheetId + '> Export as Google </button><div class="g-signin2" data-onsuccess=' + this.onSignIn + '></div></div><div id=' + this.canvasContinerId + ' ></div></div></div></div></div>';

and

simple-data-grapher/src/View.js

Lines 113 to 115 in fa222a4

    
           exportSheet(){ 
        
               console.log("clicked"); 
        
           }

in https://github.com/publiclab/simple-data-grapher/blob/main/src/View.js

🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
📝 Update
💾 Commit your changes
🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.

🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

The text was updated successfully, but these errors were encountered:

noah56 · 2019-07-24T15:38:40Z

Hi! I'm new to GitHub but would like to start contributing to some open source projects. I have removed the lines from Vew.js. Do I also need to remove the "<button type="button" class=..." from some other file?

IshaGupta18 · 2019-07-24T20:44:02Z

No this one only, can you create a PR for this? Thanks a lot!

…

On Wed, Jul 24, 2019, 9:08 PM Noah ***@***.***> wrote: Hi! I'm new to GitHub but would like to start contributing to some open source projects. I have removed the lines from Vew.js. Do I also need to remove the "<button type="button" class=..." from some other file? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#68?email_source=notifications&email_token=AJXHQZ6MZ45XCDQYSKMW2FTQBBZQFA5CNFSM4IFYHIZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2WXSPQ#issuecomment-514685246>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJXHQZZNWOFLIZF3QGGR4BLQBBZQFANCNFSM4IFYHIZQ> .

gaddeharsha13 · 2019-09-09T20:04:30Z

Hi is this still open? Can I claim this issue?

IshaGupta18 · 2019-09-09T20:06:44Z

Yes, please go ahead!

sianlouisa · 2019-10-01T08:53:54Z

Hi, I'd like to work on this if it isn't currently in progress? Thanks!

IshaGupta18 · 2019-10-01T10:33:19Z

Yes go ahead!

…

On Tue, Oct 1, 2019, 2:23 PM Sian Lynch ***@***.***> wrote: Hi, I'd like to work on this if it isn't currently in progress? Thanks! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#68?email_source=notifications&email_token=AJXHQZZD2FWRQBUMNB6C36TQMMF2HA5CNFSM4IFYHIZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAAQOOY#issuecomment-536938299>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJXHQZ234FNO7FLMD5GGWQTQMMF2HANCNFSM4IFYHIZQ> .

dsuarezlogans · 2019-10-01T21:32:57Z

Hello! is still available to work on? I'm first timer and I'll like to start with this Issue

IshaGupta18 · 2019-10-02T04:12:34Z

I think someone is working on it already?

…

On Wed, Oct 2, 2019, 3:02 AM Danny Suarez ***@***.***> wrote: Hello! is still available to work on? I'm first timer and I'll like to start with this Issue — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#68?email_source=notifications&email_token=AJXHQZ5CFPZQCVGS4YZ542DQMO6YVA5CNFSM4IFYHIZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAC2EFA#issuecomment-537240084>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJXHQZ55ADLMXG7WAACWOLLQMO6YVANCNFSM4IFYHIZQ> .

futuregit · 2019-10-10T02:20:15Z

@IshaGupta18 Hello. First-timer. I see someone is working on it already. I would like to contribute, but I'm not sure where to start?

skathuria29 · 2019-10-24T10:34:21Z

Hi! Is this issue still up for grabs ?

IshaGupta18 · 2019-10-24T15:09:47Z

If there is no PR for it, go for it!

…

On Thu, Oct 24, 2019, 4:04 PM Saloni Kathuria ***@***.***> wrote: Hi! Is this issue still up for grabs ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#68?email_source=notifications&email_token=AJXHQZ753LBYAUIR5GNY453QQF225A5CNFSM4IFYHIZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECERZ7Q#issuecomment-545856766>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJXHQZY64PPCMP6QE6HDEJTQQF225ANCNFSM4IFYHIZQ> .

anuk79 · 2019-10-27T06:57:13Z

@IshaGupta18 Hi, if no one is working on this, can I pick this up?

IshaGupta18 · 2019-10-27T07:05:15Z

If there is no PR, go for it!

…

On Sun, Oct 27, 2019, 12:27 PM Anuradha ***@***.***> wrote: @IshaGupta18 <https://github.com/IshaGupta18> Hi, if no one is working on this, can I pick this up? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#68?email_source=notifications&email_token=AJXHQZYKCF7PZNSQKMOGXOLQQU3UXA5CNFSM4IFYHIZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECKXWIY#issuecomment-546667299>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJXHQZZ7E7NL4KUWTSEUOB3QQU3UXANCNFSM4IFYHIZQ> .

anuk79 · 2019-10-27T12:05:53Z

One pr has already been merged, so this issue can be closed I guess.

jywarren · 2019-10-28T18:46:19Z

Thank you!

IshaGupta18 added good first issue Good for newcomers first-timers-only labels Jul 22, 2019

akramkazmi71 mentioned this issue Jul 22, 2019

Lines removed from file. #70

Open

2 tasks

noah56 mentioned this issue Jul 25, 2019

Removed unused code from View.js #72

Closed

4 tasks

jywarren closed this as completed Oct 28, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removing unused code #68

Removing unused code #68

IshaGupta18 commented Jul 22, 2019

noah56 commented Jul 24, 2019

IshaGupta18 commented Jul 24, 2019 via email

gaddeharsha13 commented Sep 9, 2019

IshaGupta18 commented Sep 9, 2019

sianlouisa commented Oct 1, 2019

IshaGupta18 commented Oct 1, 2019 via email

dsuarezlogans commented Oct 1, 2019

IshaGupta18 commented Oct 2, 2019 via email

futuregit commented Oct 10, 2019

skathuria29 commented Oct 24, 2019

IshaGupta18 commented Oct 24, 2019 via email

anuk79 commented Oct 27, 2019

IshaGupta18 commented Oct 27, 2019 via email

anuk79 commented Oct 27, 2019

jywarren commented Oct 28, 2019

Removing unused code #68

Removing unused code #68

Comments

IshaGupta18 commented Jul 22, 2019

🤔 What you will need to know.

Problem

📋Solution

🤔❓ Questions?

Is someone else already working on this?

noah56 commented Jul 24, 2019

IshaGupta18 commented Jul 24, 2019 via email

gaddeharsha13 commented Sep 9, 2019

IshaGupta18 commented Sep 9, 2019

sianlouisa commented Oct 1, 2019

IshaGupta18 commented Oct 1, 2019 via email

dsuarezlogans commented Oct 1, 2019

IshaGupta18 commented Oct 2, 2019 via email

futuregit commented Oct 10, 2019

skathuria29 commented Oct 24, 2019

IshaGupta18 commented Oct 24, 2019 via email

anuk79 commented Oct 27, 2019

IshaGupta18 commented Oct 27, 2019 via email

anuk79 commented Oct 27, 2019

jywarren commented Oct 28, 2019