Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint Failure during Upgrade: go version mismatch #372

Closed
iwahbe opened this issue Mar 20, 2023 · 2 comments · Fixed by #373
Closed

Lint Failure during Upgrade: go version mismatch #372

iwahbe opened this issue Mar 20, 2023 · 2 comments · Fixed by #373
Assignees
Labels
kind/bug Some behavior is incorrect or out of spec p0 A bug severe enough to interrupt existing work resolution/fixed This issue was fixed
Milestone

Comments

@iwahbe
Copy link
Member

iwahbe commented Mar 20, 2023

What happened?

See https://github.com/pulumi/pulumi-newrelic/actions/runs/4467875808/jobs/7847891395?pr=396

Expected Behavior

Lints pass

Steps to reproduce

Run a standard upgrade

Output of pulumi about

NA.

Additional context

We should pin the go version used, then roll out updates from CI mgtm.

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@iwahbe iwahbe added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Mar 20, 2023
@AaronFriel
Copy link
Member

This looks like an opportunity to replace the golangci-lint container with a better job, which has caused us trouble once this quarter already (#324, #330).

@iwahbe iwahbe removed the needs-triage Needs attention from the triage team label Mar 20, 2023
@iwahbe iwahbe self-assigned this Mar 20, 2023
@iwahbe iwahbe added the p0 A bug severe enough to interrupt existing work label Mar 20, 2023
@iwahbe
Copy link
Member Author

iwahbe commented Mar 20, 2023

This looks like an opportunity to replace the golangci-lint container with a better job, which has caused us trouble once this quarter already (#324, #330).

In this case, I actually don't blame the lint action. We specified the container as latest, but pinned the go version we were using.

The solution here is to just pin both versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec p0 A bug severe enough to interrupt existing work resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants