Skip to content

Commit

Permalink
Cache Go builds on sdk/go.sum (#2483)
Browse files Browse the repository at this point in the history
This is an unusual repository - go.sum changes all the time, while there are not so many parallel builds. This means
that typically all PRs have cache misses because they edit some go.sum somewhere. It would be preferable to fetch the
wrong build cache, hoping some parts of it still speed up the build, than it is to accept a cache miss.

This PR relies on the fact that sdk/go.sum is fairly stable, and uses it as a key. This is less precise but might be
preferable.
  • Loading branch information
t0yv0 committed Apr 24, 2023
1 parent 5a053a7 commit 276e17c
Show file tree
Hide file tree
Showing 8 changed files with 34 additions and 34 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down Expand Up @@ -153,7 +153,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down Expand Up @@ -201,7 +201,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down Expand Up @@ -271,7 +271,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down Expand Up @@ -333,7 +333,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down Expand Up @@ -394,7 +394,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down Expand Up @@ -504,7 +504,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/master.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down Expand Up @@ -157,7 +157,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down Expand Up @@ -207,7 +207,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Setup Node
uses: actions/setup-node@v2
with:
Expand Down Expand Up @@ -284,7 +284,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down Expand Up @@ -347,7 +347,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down Expand Up @@ -410,7 +410,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down Expand Up @@ -521,7 +521,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/nightly-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down Expand Up @@ -147,7 +147,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down Expand Up @@ -250,7 +250,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/prerelease.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down Expand Up @@ -147,7 +147,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Setup Node
uses: actions/setup-node@v2
with:
Expand Down Expand Up @@ -224,7 +224,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down Expand Up @@ -288,7 +288,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down Expand Up @@ -351,7 +351,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down Expand Up @@ -462,7 +462,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down Expand Up @@ -161,7 +161,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down Expand Up @@ -238,7 +238,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down Expand Up @@ -301,7 +301,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down Expand Up @@ -364,7 +364,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down Expand Up @@ -489,7 +489,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/run-acceptance-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down Expand Up @@ -170,7 +170,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Setup Node
uses: actions/setup-node@v2
with:
Expand Down Expand Up @@ -290,7 +290,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-bridge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-upstream-provider.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
with:
go-version: ${{matrix.goversion}}
cache-dependency-path: |
**/go.sum
sdk/go.sum
- name: Install pulumictl
uses: jaxxstorm/action-install-gh-release@v1.5.0
with:
Expand Down

0 comments on commit 276e17c

Please sign in to comment.