Add a smoke test of the patched upstream provider

In upstream/ we have the underlying provider code, patched with our own
improvements. There are runtime checks -- for example, that resources
are not declared more than once -- so, it is worth paying attention to
any error return value when calling NewProvider.

 - add a test that instantiating NewProvider doesn't return an error
 - panic if NewProvider returns an error (though we might hope the above
   test catches that)

Signed-off-by: Michael Bridgen <mbridgen@pulumi.com>

provider/shim/shim.go

@@ -7,6 +7,9 @@ import (
 )
 
 func NewProvider() *schema.Provider {
-	prov, _ := provider.New(context.Background())
+	prov, err := provider.New(context.Background())
+	if err != nil {
+		panic(err)
+	}
 	return prov
 }

provider/shim/shim_test.go

@@ -0,0 +1,30 @@
+// Copyright 2023, Pulumi Corporation.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package shim
+
+import (
+	"context"
+	"testing"
+
+	"github.com/hashicorp/terraform-provider-aws/internal/provider"
+)
+
+// This checks that any runtime checks in the underlying provider (with patches) are passed.
+func TestProviderShim(t *testing.T) {
+	_, err := provider.New(context.Background())
+	if err != nil {
+		t.Fatal(err)
+	}
+}