Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tf-bridge to v3.40.0 and p/p to v3.53.1 #2366

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

thomas11
Copy link
Contributor

No description provided.

@github-actions
Copy link

Does the PR have any schema changes?

Found 2 breaking changes:
Type "aws:fsx/OntapStorageVirtualMachineEndpointIscse:OntapStorageVirtualMachineEndpointIscse" missing
Type "aws:fsx/OntapStorageVirtualMachineEndpoint:OntapStorageVirtualMachineEndpoint" missing property "iscses"
No new resources/functions.

Copy link
Contributor

@rquitales rquitales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rquitales
Copy link
Contributor

Does the PR have any schema changes?

Found 2 breaking changes: Type "aws:fsx/OntapStorageVirtualMachineEndpointIscse:OntapStorageVirtualMachineEndpointIscse" missing Type "aws:fsx/OntapStorageVirtualMachineEndpoint:OntapStorageVirtualMachineEndpoint" missing property "iscses" No new resources/functions.

Should we be concerned that 2 breaking changes were found despite only the bridge and pu/pu being updated?

@thomas11 thomas11 merged commit 4b8e587 into master Feb 13, 2023
@thomas11 thomas11 deleted the tkappler/tf-bridge-3.40 branch February 13, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants