Auto-generate IAM policies #2393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
Manually merge generated definitions with existing code.
danielrbradley
force-pushed
the
generate-iam-policies
branch
from
2193e83
to
3a06a20
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
|
Ok, we've got a silly problem. Python adds {Name: "AWSCloudTrail_FullAccess", Value: "arn:aws:iam::aws:policy/AWSCloudTrail_FullAccess"},
{Name: "AWSCloudTrailFullAccess", Value: "arn:aws:iam::aws:policy/AWSCloudTrailFullAccess"},In python these are generated as AWS_CLOUD_TRAIL_FULL_ACCESS = "arn:aws:iam::aws:policy/AWSCloudTrail_FullAccess"
AWS_CLOUD_TRAIL_FULL_ACCESS = "arn:aws:iam::aws:policy/AWSCloudTrailFullAccess" |
- Add notes for manual changes. - Remove prefix for clashing names as has been done elsewhere in the past.
|
Logged an issue around the python conflicts (pulumi/pulumi#12314) and am just using the approach used elsewhere in the enum - to drop the leading "AWS" or "Amazon" on the new names. |
danielrbradley
force-pushed
the
generate-iam-policies
branch
from
3a06a20
to
f99b8db
Compare
thomas11
approved these changes
Mar 1, 2023
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually merge generated definitions with existing code.
Fixes #2269
Superceeds #2384