Upgrade upstream to v4.57.0

[danielrbradley]

Revert MaxItems changes in EC2 Fleet launchTemplateConfig and ECS clientAlias to maintain SDK backward compatibility as per our backward compatibility guidelines:

https://github.com/pulumi/platform-providers-team/blob/main/playbooks/maxitemsone.md

[...] For non-major version upgrades of Tier 1 providers, we will typically err on the side of keeping MaxItems: 1 to avoid breaking our users' code even if it is an unnecessary restriction [...]

[github-actions]

Does the PR have any schema changes?

Found 6 breaking changes:
Resource "aws:ec2/fleet:Fleet" missing input "launchTemplateConfig"
Resource "aws:ec2/fleet:Fleet" missing output "launchTemplateConfig"
Type "aws:ecs/ServiceServiceConnectConfigurationService:ServiceServiceConnectConfigurationService" missing property "clientAliases"
Type "aws:ecs/ServiceServiceConnectConfiguration:ServiceServiceConnectConfiguration" missing property "service"
Type "aws:autoscaling/PolicyPredictiveScalingConfigurationMetricSpecification:PolicyPredictiveScalingConfigurationMetricSpecification" input "targetValue" type changed from "integer" to "number"
Type "aws:appflow/FlowSourceFlowConfigSourceConnectorPropertiesSapoData:FlowSourceFlowConfigSourceConnectorPropertiesSapoData" missing property "object"

New resources:

• ec2/vpcIpamResourceDiscovery.VpcIpamResourceDiscovery
• ec2/vpcIpamResourceDiscoveryAssociation.VpcIpamResourceDiscoveryAssociation
• lightsail/bucketResourceAccess.BucketResourceAccess
• networkmanager/connectPeer.ConnectPeer

New functions:

• organizations/getOrganizationalUnitChildAccounts.getOrganizationalUnitChildAccounts
• organizations/getOrganizationalUnitDescendantAccounts.getOrganizationalUnitDescendantAccounts

[squaremo]

Looks sound; I will have a look at the rebased upstream/, too. The breaking changes reported will need chasing down, to make sure they are expected.
My comments here are mainly queries about what's going on -- it's hard to understand the changes to replacements.json (though I prefer it to the prior state of the art!).

[squaremo]

This looks really similar (and in the same place, I think, under the key "website/docs/r/s3_bucket.html.markdown") to a replacement that was added in the previous commit. I'm not clear what this means -- does the text get changed now, and not removed?

[danielrbradley]

Issue investigation:

• EC2 Fleet launchTemplateConfig has changed from being exactly 1 element to being between 0 and 50 elements. This causes our property to be renamed to a plural. Resolution: reinstateMaxItemsOne: true, so the type and field name don't change and break user code.
• ECS ServiceServiceConnectConfigurationService clientAlias has now added maxItems 1, but optional - so no more pluralisation. Resolution: remove MaxItemsOne: true, so the type and field name don't change
• Autoscaling PolicyPredictiveScalingConfigurationMetricSpecification targetValue has had its type changed upstream from int to float. Resolution: leave it, on the basis that it's low impact.
• AppFlow FlowSourceFlowConfigSourceConnectorPropertiesSapoData object property has been renamed to AttrObjectPath. ResolutionL leave it, on the basis that it's low impact.

Investigating if there's a fix for the first two.
(EDIT: made this into a checklist)

[squaremo]

Could you explain the justification for the MaxItemsOne reversion in the commit message, please. (I'd include a link to the breaking changes policy, too.) As recently as this particular update, a (rebased) commit that didn't come with an explanation held us up until we could chase down why it was done. This change is less likely to cause difficulties during a rebase specifically, but there are other situations in which having the explanation with the change avoids hold-ups.

[github-actions]

Does the PR have any schema changes?

Found 4 breaking changes:
Type "aws:appflow/FlowSourceFlowConfigSourceConnectorPropertiesSapoData:FlowSourceFlowConfigSourceConnectorPropertiesSapoData" missing property "object"
Type "aws:ecs/ServiceServiceConnectConfigurationService:ServiceServiceConnectConfigurationService" missing property "clientAliases"
Type "aws:ecs/ServiceServiceConnectConfiguration:ServiceServiceConnectConfiguration" missing property "service"
Type "aws:autoscaling/PolicyPredictiveScalingConfigurationMetricSpecification:PolicyPredictiveScalingConfigurationMetricSpecification" input "targetValue" type changed from "integer" to "number"

New resources:

• ec2/vpcIpamResourceDiscovery.VpcIpamResourceDiscovery
• ec2/vpcIpamResourceDiscoveryAssociation.VpcIpamResourceDiscoveryAssociation
• lightsail/bucketResourceAccess.BucketResourceAccess
• networkmanager/connectPeer.ConnectPeer

New functions:

• organizations/getOrganizationalUnitChildAccounts.getOrganizationalUnitChildAccounts
• organizations/getOrganizationalUnitDescendantAccounts.getOrganizationalUnitDescendantAccounts