Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export patches to local repo #2414

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Export patches to local repo #2414

merged 2 commits into from
Apr 12, 2023

Conversation

danielrbradley
Copy link
Member

@danielrbradley danielrbradley commented Mar 15, 2023

Aim: We want to be able to review how patches have evolved between upgrades.

  1. Find commits since the lastest tag in the upstream repo
  2. Commit patch files into a subfolder for review

Example diff for last upgrade: https://github.com/pulumi/pulumi-aws/compare/5.30.1-patches..export-patches-to-repo

@danielrbradley danielrbradley requested a review from a team March 15, 2023 18:10
@danielrbradley danielrbradley self-assigned this Mar 15, 2023
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@danielrbradley danielrbradley marked this pull request as ready for review April 11, 2023 19:02
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
Skip running upstream patch export if shallow:
- Git will fail if our upstream checkout is shallow (e.g. in CI).
- Refactor exporting upstream patches into its own target.
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@danielrbradley danielrbradley merged commit e466d93 into master Apr 12, 2023
15 checks passed
@danielrbradley danielrbradley deleted the export-patches-to-repo branch April 12, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants