Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade terraform-provider-aws to v4.60.0 #2440

Merged
merged 6 commits into from
Mar 30, 2023
Merged

Upgrade terraform-provider-aws to v4.60.0 #2440

merged 6 commits into from
Mar 30, 2023

Conversation

thomas11
Copy link
Contributor

In our fork, this upgrade required reverting the migration of cognitoidp to the plugin framework. I've tried to logically follow this PR but am unsure how to make sure the result is correct.

resolves #2422

@thomas11 thomas11 requested review from danielrbradley and a team March 29, 2023 02:35
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.

New resources:

  • oam/link.Link
  • sesv2/contactList.ContactList

New functions:

  • appmesh/getRoute.getRoute
  • appmesh/getVirtualGateway.getVirtualGateway

danielrbradley
danielrbradley approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@danielrbradley danielrbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fine to me.

Only comment I'd make on your new framework reverts is that you'd deleted a whole file - this could cause conflicts so it might be worth switching to just excluding it from the build with an exclude build flag.

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.

New resources:

  • oam/link.Link
  • sesv2/contactList.ContactList

New functions:

  • appmesh/getRoute.getRoute
  • appmesh/getVirtualGateway.getVirtualGateway

1 similar comment
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.

New resources:

  • oam/link.Link
  • sesv2/contactList.ContactList

New functions:

  • appmesh/getRoute.getRoute
  • appmesh/getVirtualGateway.getVirtualGateway

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.

New resources:

  • oam/link.Link
  • sesv2/contactList.ContactList

New functions:

  • appmesh/getRoute.getRoute
  • appmesh/getVirtualGateway.getVirtualGateway

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.

New resources:

  • oam/link.Link
  • sesv2/contactList.ContactList

New functions:

  • appmesh/getRoute.getRoute
  • appmesh/getVirtualGateway.getVirtualGateway

@thomas11 thomas11 merged commit 842f081 into master Mar 30, 2023
15 checks passed
@thomas11 thomas11 deleted the tkappler/v4.60.0 branch March 30, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielrbradley danielrbradley danielrbradley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade terraform-provider-aws to v4.60.0
2 participants
@thomas11 @danielrbradley