-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom build parallelism #2472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my end. We should probably make sure that someone from @pulumi/providers gives it the 👌.
@@ -13,6 +13,7 @@ JAVA_GEN_VERSION := v0.7.1 | |||
TESTPARALLELISM := 10 | |||
WORKING_DIR := $(shell pwd) | |||
SCHEMA_TOOLS_VERSION := $(shell cat .schema-tools.version) | |||
PULUMI_PROVIDER_BUILD_PARALLELISM ?= -p 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a behavior change from -p 1 but @thomas11 recommended this. We can make it -p 1 so it wouldn't be a behavior change. Still lets me run with -p 6 locally.
Does the PR have any schema changes?Looking good! No breaking changes found. |
b/sdk/go/aws/cognito/identityPoolRoleAttachment.go strikes again, interesting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b/sdk/go/aws/cognito/identityPoolRoleAttachment.go is flaky. rerunning fixed it. |
Same change as just got rolled out to ecosystem providers pulumi/ci-mgmt#386 - applied manually to this provider.