Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom build parallelism #2472

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Allow custom build parallelism #2472

merged 1 commit into from
Apr 20, 2023

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Apr 19, 2023

Same change as just got rolled out to ecosystem providers pulumi/ci-mgmt#386 - applied manually to this provider.

@t0yv0 t0yv0 requested review from thomas11 and iwahbe April 19, 2023 18:24
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my end. We should probably make sure that someone from @pulumi/providers gives it the 👌.

@t0yv0 t0yv0 requested a review from kpitzen April 19, 2023 18:52
@@ -13,6 +13,7 @@ JAVA_GEN_VERSION := v0.7.1
TESTPARALLELISM := 10
WORKING_DIR := $(shell pwd)
SCHEMA_TOOLS_VERSION := $(shell cat .schema-tools.version)
PULUMI_PROVIDER_BUILD_PARALLELISM ?= -p 2
Copy link
Member Author

@t0yv0 t0yv0 Apr 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a behavior change from -p 1 but @thomas11 recommended this. We can make it -p 1 so it wouldn't be a behavior change. Still lets me run with -p 6 locally.

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@t0yv0
Copy link
Member Author

t0yv0 commented Apr 19, 2023

b/sdk/go/aws/cognito/identityPoolRoleAttachment.go strikes again, interesting.

Makefile Show resolved Hide resolved
Copy link
Contributor

@rquitales rquitales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Makefile Show resolved Hide resolved
@t0yv0
Copy link
Member Author

t0yv0 commented Apr 20, 2023

b/sdk/go/aws/cognito/identityPoolRoleAttachment.go is flaky. rerunning fixed it.

@t0yv0 t0yv0 merged commit 438c31f into master Apr 20, 2023
17 checks passed
@t0yv0 t0yv0 deleted the t0yv0/build-parallelism branch April 20, 2023 03:19
@t0yv0 t0yv0 self-assigned this Apr 20, 2023
@t0yv0 t0yv0 added this to the 0.87 milestone Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants