Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add go build caching for the shim testing job #2478

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Add go build caching for the shim testing job #2478

merged 2 commits into from
Apr 20, 2023

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Apr 20, 2023 •
edited

Introduce Go caching on the "Run test of provider shim" job to reduce flaky timeouts and reduce runtime from 30min to <2 min total.

@t0yv0 t0yv0 marked this pull request as ready for review April 20, 2023 15:16
thomas11
thomas11 approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@thomas11 thomas11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The repetition is painful but obviously unrelated to this PR.

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@t0yv0 t0yv0 merged commit 7079c65 into master Apr 20, 2023
15 of 17 checks passed
@t0yv0 t0yv0 deleted the t0yv0/build-cache-for-testing-shim branch April 20, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas11 thomas11 thomas11 approved these changes

@rquitales rquitales Awaiting requested review from rquitales

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@t0yv0 @thomas11