Cache Go builds on sdk/go.sum #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
This is an unusual repository - go.sum changes all the time, while there are not so many parallel builds. This means that typically all PRs have cache misses because they edit some go.sum somewhere. It would be preferable to fetch the wrong build cache, hoping some parts of it still speed up the build, than it is to accept a cache miss. This PR relies on the fact that sdk/go.sum is fairly stable, and uses it as a key. This is less precise but might be preferable.
t0yv0
force-pushed
the
t0yv0/cache-go-builds-on-sdk-sum
branch
from
8801558
to
6fa1a7e
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an unusual repository - go.sum changes all the time, while there are not so many parallel builds. This means that typically all PRs have cache misses because they edit some go.sum somewhere. It would be preferable to fetch the wrong build cache (and rewrite it in each PR), hoping some parts of it still speed up the build, than it is to accept a cache miss.
This PR relies on the fact that sdk/go.sum is fairly stable, and uses it as a key. This is less precise but might be preferable.