Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of support for x-ms-skip-url-encoding causes incorrect request URLs #3118

Open
thomas11 opened this issue Feb 29, 2024 · 0 comments
Open
Labels
kind/enhancement Improvements or new features

Comments

@thomas11
Copy link
Contributor

Way back in #20 we determined that we didn't need the x-ms-skip-url-encoding of the Azure spec at the time. That has changed in the meantime.

For instance, azure-native:authorization:RoleDefinition has this path in metadata: /{scope}/providers/Microsoft.Authorization/roleDefinitions/{roleDefinitionId}. A typical scope like in our examples/keyvault test is /subscriptions/123.... Note that it contains two slashes.

Since it’s a URL path parameter, the provider escapes scope to %2Fsubscriptions%2F0123.... That is incorrect since the scope property is annotated with x-ms-skip-url-encoding, and leads to an incorrect request URL.

Fortunately, everything works in this case, probably because the Azure endpoint is forgiving of its input. We should still fix this, though.

@thomas11 thomas11 added the kind/enhancement Improvements or new features label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

1 participant