Skip to content

Commit

Permalink
Allow token to be discovered by env var (#578)
Browse files Browse the repository at this point in the history
Allow `token` to be set via the `GITHUB_TOKEN` env var.

This provides a partial workaround for
#203.
  • Loading branch information
iwahbe committed Feb 28, 2024
1 parent d703468 commit 5e777d6
Show file tree
Hide file tree
Showing 13 changed files with 79 additions and 12 deletions.
19 changes: 16 additions & 3 deletions provider/cmd/pulumi-resource-github/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,13 @@
},
"token": {
"type": "string",
"description": "The OAuth token used to connect to GitHub. Anonymous mode is enabled if both `token` and `app_auth` are not set.\n"
"description": "The OAuth token used to connect to GitHub. Anonymous mode is enabled if both `token` and `app_auth` are not set.\n",
"defaultInfo": {
"environment": [
"GITHUB_TOKEN"
]
},
"secret": true
},
"writeDelayMs": {
"type": "integer",
Expand Down Expand Up @@ -2865,7 +2871,8 @@
},
"token": {
"type": "string",
"description": "The OAuth token used to connect to GitHub. Anonymous mode is enabled if both `token` and `app_auth` are not set.\n"
"description": "The OAuth token used to connect to GitHub. Anonymous mode is enabled if both `token` and `app_auth` are not set.\n",
"secret": true
},
"writeDelayMs": {
"type": "integer",
Expand Down Expand Up @@ -2925,7 +2932,13 @@
},
"token": {
"type": "string",
"description": "The OAuth token used to connect to GitHub. Anonymous mode is enabled if both `token` and `app_auth` are not set.\n"
"description": "The OAuth token used to connect to GitHub. Anonymous mode is enabled if both `token` and `app_auth` are not set.\n",
"defaultInfo": {
"environment": [
"GITHUB_TOKEN"
]
},
"secret": true
},
"writeDelayMs": {
"type": "integer",
Expand Down
6 changes: 6 additions & 0 deletions provider/resources.go
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,12 @@ func Provider() tfbridge.ProviderInfo {
Value: "https://api.github.com/",
},
},
"token": {
Default: &tfbridge.DefaultInfo{
EnvVars: []string{"GITHUB_TOKEN"},
},
Secret: tfbridge.True(),
},
},
Resources: map[string]*tfbridge.ResourceInfo{
"github_actions_environment_secret": {DeleteBeforeReplace: true},
Expand Down
2 changes: 1 addition & 1 deletion sdk/dotnet/Config/Config.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 17 additions & 2 deletions sdk/dotnet/Provider.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 9 additions & 1 deletion sdk/go/github/config/config.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions sdk/go/github/provider.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion sdk/java/src/main/java/com/pulumi/github/Config.java

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions sdk/java/src/main/java/com/pulumi/github/Provider.java

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions sdk/java/src/main/java/com/pulumi/github/ProviderArgs.java

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion sdk/nodejs/config/vars.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion sdk/nodejs/provider.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion sdk/python/pulumi_github/config/vars.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion sdk/python/pulumi_github/provider.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 5e777d6

Please sign in to comment.