Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of Custom Role resource not supported? #293

Closed
jetersen opened this issue Jan 19, 2023 · 7 comments
Closed

Creation of Custom Role resource not supported? #293

jetersen opened this issue Jan 19, 2023 · 7 comments
Labels
awaiting-upstream Awaiting upstream dependency kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@jetersen
Copy link

Hello!

https://github.com/integrations/terraform-provider-github/releases/tag/v5.10.0 mentions support for custom roles but I cannot see it in the documentation.

https://www.pulumi.com/registry/packages/github/api-docs/

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Custom roles is a GitHuB teams feature

Affected area/feature

N/A

@jetersen jetersen added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Jan 19, 2023
@iwahbe iwahbe added kind/enhancement Improvements or new features resolution/by-design This issue won't be fixed because the functionality is working as designed and removed kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Jan 19, 2023
@iwahbe
Copy link
Member

iwahbe commented Jan 19, 2023

Hi @jetersen. We document support for custom roles on the resource they apply to: github.RepositoryCollaborator. We mention them here for the permission input:
Screenshot 2023-01-19 at 2 24 56 PM

Note: All our documentation is taken from the upstream provider for bridged providers.

@iwahbe iwahbe closed this as not planned Won't fix, can't repro, duplicate, stale Jan 19, 2023
@jetersen
Copy link
Author

jetersen commented Jan 20, 2023

Ah bad naming I was expecting the name of CustomRole 😓

Edit: Well actually that is still no resource for defining these custom roles on an org level.

@jetersen jetersen changed the title Custom Role not supported? Creation of Custom Role resource not supported? Jan 20, 2023
@jetersen
Copy link
Author

@iwahbe would mind reopening? 😊

@iwahbe
Copy link
Member

iwahbe commented Jan 20, 2023

Sure. It sounds like the issue wasn't about missing documentation, but support for a resource that creates custom roles. Does that sound right?

Dispite https://github.com/integrations/terraform-provider-github/releases/tag/v5.10.0, I don't think that the upstream provider has support for creating custom roles. The tracking issue for adding that feature is integrations/terraform-provider-github#1069.

@iwahbe iwahbe reopened this Jan 20, 2023
@iwahbe iwahbe added awaiting-upstream Awaiting upstream dependency and removed resolution/by-design This issue won't be fixed because the functionality is working as designed labels Jan 20, 2023
@Jamess-Lucass
Copy link

Jamess-Lucass commented Sep 13, 2023

I believe this issue can be closed, the related issue integrations/terraform-provider-github#1069 has been closed and OrganizationCustomRole has been added to the pulumi sdk.

@ericrudder
Copy link
Member

thanks @Jamess-Lucass [btw, you don't look 23! :)]

@iwahbe iwahbe added the resolution/fixed This issue was fixed label Sep 13, 2023
@iwahbe iwahbe closed this as completed Sep 13, 2023
@Jamess-Lucass
Copy link

thanks @Jamess-Lucass [btw, you don't look 23! :)]

hahaha, that photo was taken many moons ago :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-upstream Awaiting upstream dependency kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

4 participants