Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch BranchProtection state migration #594

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Patch BranchProtection state migration #594

merged 3 commits into from
Mar 6, 2024

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Mar 6, 2024

Fixes #586

@iwahbe iwahbe requested a review from a team March 6, 2024 17:29
@iwahbe iwahbe self-assigned this Mar 6, 2024
Copy link

github-actions bot commented Mar 6, 2024

Does the PR have any schema changes?

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link
Contributor

@VenelinMartinov VenelinMartinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iwahbe iwahbe enabled auto-merge (squash) March 6, 2024 17:50
@iwahbe iwahbe merged commit 39cb3a4 into master Mar 6, 2024
17 checks passed
@iwahbe iwahbe deleted the iwahbe/586/fix branch March 6, 2024 18:07
"github.com/pulumi/pulumi-github/provider/v6/pkg/version"
)

const repro586 = `[
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be adventurous and actually use provdertest upgrade tests here :) But this works.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do that next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[panic] State migration of BranchProtection from v5 -> v6 fails
3 participants