{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":116869354,"defaultBranch":"master","name":"pulumi-kubernetes","ownerLogin":"pulumi","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2018-01-09T20:50:33.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/21992475?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1715844328.0","currentOid":""},"activityList":{"items":[{"before":"98aac37ba217824da91819bbf062bde689bd7b6d","after":null,"ref":"refs/heads/update-github-actions-workflows-273","pushedAt":"2024-05-16T07:25:28.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"pulumi-bot","name":"Pulumi Bot","path":"/pulumi-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30351955?s=80&v=4"}},{"before":"e7249ac562127f06e1eecfa94a8644b9726bea8f","after":"675c6305139e84e69243d5746dfa6277e38fca42","ref":"refs/heads/master","pushedAt":"2024-05-16T07:25:27.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"pulumi-bot","name":"Pulumi Bot","path":"/pulumi-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30351955?s=80&v=4"},"commit":{"message":"Update GitHub Actions workflows. (#3008)\n\nThis PR was automatically generated by the\nupdate-native-provider-workflows workflow in the pulumi/ci-mgmt repo,\nfrom commit 2c4960e091c66f59df2902620e003f2db1a7b063.","shortMessageHtmlLink":"Update GitHub Actions workflows. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2299362218\" data-permission-text=\"Title is private\" data-url=\"https://github.com/pulumi/pulumi-kubernetes/issues/3008\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/pulumi/pulumi-kubernetes/pull/3008/hovercard\" href=\"https://github.com/pulumi/pulumi-kubernetes/pull/3008\">#3008</a>)"}},{"before":null,"after":"98aac37ba217824da91819bbf062bde689bd7b6d","ref":"refs/heads/update-github-actions-workflows-273","pushedAt":"2024-05-16T05:06:02.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"pulumi-bot","name":"Pulumi Bot","path":"/pulumi-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/30351955?s=80&v=4"},"commit":{"message":"[internal] Update GitHub Actions workflow files","shortMessageHtmlLink":"[internal] Update GitHub Actions workflow files"}},{"before":null,"after":"60679525f7189fc807cc41cb279e1630adad02c7","ref":"refs/heads/blampe/flake","pushedAt":"2024-05-16T00:08:16.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"blampe","name":"Bryce Lampe","path":"/blampe","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/848843?s=80&v=4"},"commit":{"message":"Scope yamlv2 CRDs to fix test flake","shortMessageHtmlLink":"Scope yamlv2 CRDs to fix test flake"}},{"before":"ad5873258c7fbb622e493c4ad49779b49d4adfa3","after":"e7249ac562127f06e1eecfa94a8644b9726bea8f","ref":"refs/heads/master","pushedAt":"2024-05-15T23:16:02.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"EronWright","name":"Eron Wright","path":"/EronWright","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1775518?s=80&v=4"},"commit":{"message":"Helm Chart v4 (Component) (#2947)\n\n<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)\r\n    for Pulumi's contribution guidelines.\r\n\r\n    Help us merge your changes more quickly by adding more details such\r\n    as labels, milestones, and reviewers.-->\r\n\r\n### Proposed changes\r\n\r\n<!--Give us a brief description of what you've done and what it solves.\r\n-->\r\nThis PR implements an MLC-based `Chart` resource as per [design\r\ndoc](https://docs.google.com/document/d/1_DZlsAyG4-3BxrAkJBj8R6wIVuzhAkxRDyq8k_Zcst4/edit?usp=sharing).\r\n\r\nNotable improvements over v3:Chart:\r\n\r\n- Input schema more closely resembles v3:Release.\r\n- Performs templating in an online mode.\r\n- More control over resource ordering via annotation:\r\n`config.kubernetes.io/depends-on`\r\n- Uses [Pulumi\r\nAssets](https://www.pulumi.com/docs/concepts/assets-archives/) for\r\nsupplemental files (keyring, repository opts).\r\n- Use assets as values files (`--values`) and as individual values\r\n(`--set-file`).\r\n- Use multiple values files.\r\n- Support for post-rendering w/ arguments.\r\n- OCI registry support.\r\n\r\nDetailed changes:\r\n- [pkg/helm] introduce a reusable Helm tool wrapper\r\n- [pkg/gen] define `helm.sh/v4:Chart` resource plus\r\n`v4:PostRenderer,v4:RepositoryOpts`\r\n- [provider] initialize the Helm EnvSettings based on provider\r\nconfiguration\r\n- [provider/helmv4] implement Chart resource provider\r\n- [provider/yamlv2] add `PreRegisterF` hook to be able to mutate child\r\nresource options, specifically `RetainOnDelete`\r\n- [provider/yamlv2] new gomega matcher: `HaveSkipAwaitAnnotation()`\r\n- [tests/testdata] new 'reference' chart for testing purposes\r\n- [misc] bugfix for kube client settings\r\n\r\nTests:\r\n- New suite for Chart provider w/ coverage of all in-scope features\r\n- Extended tests for provider Construct RPC to cover namespacing, kube\r\nclient settings, helm release settings\r\n\r\n### Examples\r\n\r\nSee the examples in the API docs:\r\n\r\nhttps://github.com/pulumi/pulumi-kubernetes/blob/47a6ae4fceb8339c49d4f13b5f765af798c0308b/provider/pkg/gen/examples/overlays/chartV4.md#example-usage\r\n\r\nLocal Chart:\r\n```yaml\r\ntype: kubernetes:helm.sh/v4:Chart\r\nproperties:\r\n  namespace: cert-manager\r\n  chart: ./cert-manager\r\n```\r\n\r\nRepository Chart:\r\n```yaml\r\n# helm repo add bitnami https://charts.bitnami.com/bitnami\r\ntype: kubernetes:helm.sh/v4:Chart\r\nproperties:\r\n  namespace: cert-manager\r\n  chart: bitnami/cert-manager\r\n  version: \"1.1.0\"\r\n```\r\n\r\nRemote Chart:\r\n```yaml\r\ntype: kubernetes:helm.sh/v4:Chart\r\nproperties:\r\n  namespace: cert-manager\r\n  chart: cert-manager\r\n  version: \"1.1.0\"\r\n  repositoryOpts:\r\n    repo: https://charts.bitnami.com/bitnami\r\n```\r\n\r\nOCI Chart:\r\n```yaml\r\ntype: kubernetes:helm.sh/v4:Chart\r\nproperties:\r\n  namespace: cert-manager\r\n  chart: oci://registry-1.docker.io/bitnamicharts/cert-manager\r\n  version: \"1.1.0\"\r\n```\r\n\r\nCustom Values:\r\n```yaml\r\ntype: kubernetes:helm.sh/v4:Chart\r\nproperties:\r\n  namespace: cert-manager\r\n  chart: oci://registry-1.docker.io/bitnamicharts/cert-manager\r\n  version: \"1.1.0\"\r\n  values:\r\n    installCRDs: false\r\n    notes:\r\n      fn::fileAsset: notes.txt\r\n  valueYamlFiles:\r\n  - fn::fileAsset: values.yaml\r\n```\r\n\r\nChart Verification w/ Keyring:\r\n```yaml\r\ntype: kubernetes:helm.sh/v4:Chart\r\nproperties:\r\n  namespace: cert-manager\r\n  chart: oci://registry-1.docker.io/eronwrightpulumi/cert-manager\r\n  version: \"1.1.0\"\r\n  verify: true\r\n  keyring:\r\n    fn::fileAsset: \"public.pgp\"\r\n```\r\n\r\nPost-Rendering:\r\n```yaml\r\ntype: kubernetes:helm.sh/v4:Chart\r\nproperties:\r\n  namespace: cert-manager\r\n  chart: oci://registry-1.docker.io/bitnamicharts/cert-manager\r\n  version: \"1.1.0\"\r\n  postRenderer:\r\n    command: ./kustomize\r\n    args: []\r\n```\r\n\r\n### Related issues (optional)\r\n\r\n<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes\r\n#1234'.\r\nOr link to full URLs to issues or pull requests in other GitHub\r\nrepositories. -->\r\n\r\nFixes #2847","shortMessageHtmlLink":"Helm Chart v4 (Component) (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2240603200\" data-permission-text=\"Title is private\" data-url=\"https://github.com/pulumi/pulumi-kubernetes/issues/2947\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/pulumi/pulumi-kubernetes/pull/2947/hovercard\" href=\"https://github.com/pulumi/pulumi-kubernetes/pull/2947\">#2947</a>)"}},{"before":"a27f40271e2ac4ecb81f93bde3889b4cbc40c999","after":null,"ref":"refs/heads/eronwright/chartv4","pushedAt":"2024-05-15T23:16:02.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"EronWright","name":"Eron Wright","path":"/EronWright","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1775518?s=80&v=4"}},{"before":"31e358926c721147e84b2cbf4cd52363c0929831","after":"a27f40271e2ac4ecb81f93bde3889b4cbc40c999","ref":"refs/heads/eronwright/chartv4","pushedAt":"2024-05-14T23:24:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"EronWright","name":"Eron Wright","path":"/EronWright","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1775518?s=80&v=4"},"commit":{"message":"feedback","shortMessageHtmlLink":"feedback"}},{"before":"47a6ae4fceb8339c49d4f13b5f765af798c0308b","after":"31e358926c721147e84b2cbf4cd52363c0929831","ref":"refs/heads/eronwright/chartv4","pushedAt":"2024-05-14T22:13:03.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"EronWright","name":"Eron Wright","path":"/EronWright","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1775518?s=80&v=4"},"commit":{"message":"tweak the linters","shortMessageHtmlLink":"tweak the linters"}},{"before":"db17b093544de9e0cb22a322dec0abee6588c7e5","after":"47a6ae4fceb8339c49d4f13b5f765af798c0308b","ref":"refs/heads/eronwright/chartv4","pushedAt":"2024-05-13T18:48:17.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"EronWright","name":"Eron Wright","path":"/EronWright","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1775518?s=80&v=4"},"commit":{"message":"go mod tidy","shortMessageHtmlLink":"go mod tidy"}},{"before":"0175f95793fc9076ad1e64fcfc3d3e621216c3ff","after":"db17b093544de9e0cb22a322dec0abee6588c7e5","ref":"refs/heads/eronwright/chartv4","pushedAt":"2024-05-13T18:37:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"EronWright","name":"Eron Wright","path":"/EronWright","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1775518?s=80&v=4"},"commit":{"message":"Java samples","shortMessageHtmlLink":"Java samples"}},{"before":"25b4b09fe89634135d69f898035c7af81194b2f0","after":"0175f95793fc9076ad1e64fcfc3d3e621216c3ff","ref":"refs/heads/eronwright/chartv4","pushedAt":"2024-05-13T17:46:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"EronWright","name":"Eron Wright","path":"/EronWright","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1775518?s=80&v=4"},"commit":{"message":"move testdata","shortMessageHtmlLink":"move testdata"}},{"before":"128f78c131eacec3fe215855f1f63574b8cd656c","after":"25b4b09fe89634135d69f898035c7af81194b2f0","ref":"refs/heads/eronwright/chartv4","pushedAt":"2024-05-13T17:41:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"EronWright","name":"Eron Wright","path":"/EronWright","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1775518?s=80&v=4"},"commit":{"message":"api: repositoryopts v4","shortMessageHtmlLink":"api: repositoryopts v4"}},{"before":"c2acfb76b39cec077b79af5222f68d44e12efd56","after":"b8bca2be1785d049025002edb63e299afedb3be7","ref":"refs/heads/blampe/ds-await","pushedAt":"2024-05-13T17:07:24.000Z","pushType":"push","commitsCount":10,"pusher":{"login":"blampe","name":"Bryce Lampe","path":"/blampe","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/848843?s=80&v=4"},"commit":{"message":"Merge branch 'master' of github.com:pulumi/pulumi-kubernetes into blampe/ds-await","shortMessageHtmlLink":"Merge branch 'master' of github.com:pulumi/pulumi-kubernetes into bla…"}},{"before":"9b293759411f87cc50ed20dce8c2a9402a423373","after":"128f78c131eacec3fe215855f1f63574b8cd656c","ref":"refs/heads/eronwright/chartv4","pushedAt":"2024-05-11T00:43:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"EronWright","name":"Eron Wright","path":"/EronWright","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1775518?s=80&v=4"},"commit":{"message":"api doc examples","shortMessageHtmlLink":"api doc examples"}},{"before":"0a4e29d0e4656c3289ab5f1ea7aec39c94d867e9","after":null,"ref":"refs/heads/blampe/2985","pushedAt":"2024-05-10T22:19:36.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"blampe","name":"Bryce Lampe","path":"/blampe","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/848843?s=80&v=4"}},{"before":"785d414946d341aa6ef1a361d0a19aa3f573c5f0","after":"ad5873258c7fbb622e493c4ad49779b49d4adfa3","ref":"refs/heads/master","pushedAt":"2024-05-10T22:19:35.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"blampe","name":"Bryce Lampe","path":"/blampe","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/848843?s=80&v=4"},"commit":{"message":"Support chart.v3 previews when cluster is unreachable (#2992)\n\nWe currently fail to render a preview for Chart V3 if the cluster is\r\nunreachable.\r\n\r\nInstead of failing, we can emit a warning since Helm is still able to\r\ngenerate the template without the version set.\r\n\r\nAlternatively, we could check `k.clusterUnreachable` as part of `Invoke`\r\nbut we wouldn't be able to return a rich preview.\r\n\r\nAdded a failing E2E test.\r\n\r\nFixes https://github.com/pulumi/pulumi-kubernetes/issues/2985.","shortMessageHtmlLink":"Support chart.v3 previews when cluster is unreachable (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2278271123\" data-permission-text=\"Title is private\" data-url=\"https://github.com/pulumi/pulumi-kubernetes/issues/2992\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/pulumi/pulumi-kubernetes/pull/2992/hovercard\" href=\"https://github.com/pulumi/pulumi-kubernetes/pull/2992\">#2992</a>)"}},{"before":"5342b6b482bab9611a1b2880a57f6778e3c3175a","after":"9b293759411f87cc50ed20dce8c2a9402a423373","ref":"refs/heads/eronwright/chartv4","pushedAt":"2024-05-10T22:19:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"EronWright","name":"Eron Wright","path":"/EronWright","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1775518?s=80&v=4"},"commit":{"message":"chartv4 api docs","shortMessageHtmlLink":"chartv4 api docs"}},{"before":"a76337a4ccf5260652acf70faaa7c3dbeeab8e48","after":"0a4e29d0e4656c3289ab5f1ea7aec39c94d867e9","ref":"refs/heads/blampe/2985","pushedAt":"2024-05-10T20:55:07.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"blampe","name":"Bryce Lampe","path":"/blampe","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/848843?s=80&v=4"},"commit":{"message":"Merge branch 'master' of github.com:pulumi/pulumi-kubernetes into blampe/2985","shortMessageHtmlLink":"Merge branch 'master' of github.com:pulumi/pulumi-kubernetes into bla…"}},{"before":"333ebf053e68e8c462b10f6f9b244ce67dfc7214","after":null,"ref":"refs/heads/blampe/pkg-errors","pushedAt":"2024-05-10T18:40:15.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"blampe","name":"Bryce Lampe","path":"/blampe","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/848843?s=80&v=4"}},{"before":"80d60f435ee36098f77b8df67b0bae0e430d15a7","after":"785d414946d341aa6ef1a361d0a19aa3f573c5f0","ref":"refs/heads/master","pushedAt":"2024-05-10T18:40:14.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"blampe","name":"Bryce Lampe","path":"/blampe","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/848843?s=80&v=4"},"commit":{"message":"Remove deprecated pkg/errors package (#2990)\n\n`errors.Wrap` can mask bugs by returning `nil` errors where a non-`nil`\r\nerror was intended. This is most common in situations where multiple\r\nerrors are being checked and the wrong (`nil`) error is wrapped:\r\n\r\n```go\r\nif err != nil {\r\n    return err\r\n}\r\nif _, otherErr := f(...); otherErr != nil {\r\n    return errors.Wrap(err, ...) // bug\r\n}\r\n```\r\nFrom spot checking our usage I don't _think_ we have any cases of this,\r\nbut we should stop using the deprecated package to be safe. Additionally\r\nthe native errors package now has `Join` and other helpers we should be\r\nusing instead.\r\n\r\nMost of this PR was programmatically generated.","shortMessageHtmlLink":"Remove deprecated pkg/errors package (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2274386706\" data-permission-text=\"Title is private\" data-url=\"https://github.com/pulumi/pulumi-kubernetes/issues/2990\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/pulumi/pulumi-kubernetes/pull/2990/hovercard\" href=\"https://github.com/pulumi/pulumi-kubernetes/pull/2990\">#2990</a>)"}},{"before":"d79769609fb1c41581dfb4a6fd5ab7312004df1a","after":"5342b6b482bab9611a1b2880a57f6778e3c3175a","ref":"refs/heads/eronwright/chartv4","pushedAt":"2024-05-10T18:08:06.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"EronWright","name":"Eron Wright","path":"/EronWright","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1775518?s=80&v=4"},"commit":{"message":"use fmt.errorf","shortMessageHtmlLink":"use fmt.errorf"}},{"before":"ecde2e108ff64cd2c2dd2c8cee3805b6af95be69","after":"333ebf053e68e8c462b10f6f9b244ce67dfc7214","ref":"refs/heads/blampe/pkg-errors","pushedAt":"2024-05-10T17:57:13.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"blampe","name":"Bryce Lampe","path":"/blampe","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/848843?s=80&v=4"},"commit":{"message":"Merge branch 'master' of github.com:pulumi/pulumi-kubernetes into blampe/pkg-errors","shortMessageHtmlLink":"Merge branch 'master' of github.com:pulumi/pulumi-kubernetes into bla…"}},{"before":"b59b5d2a7e4a0cef8c2c709584cf77a16e184410","after":"3583a1033d7bd2f085e2dc4830a8e353a87ff3fb","ref":"refs/heads/update-pulumi/9017454843-135","pushedAt":"2024-05-10T17:52:22.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"blampe","name":"Bryce Lampe","path":"/blampe","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/848843?s=80&v=4"},"commit":{"message":"Updated modules","shortMessageHtmlLink":"Updated modules"}},{"before":"43727b769afe8e1c3a1ea6a2edf49153dc1773c8","after":"a76337a4ccf5260652acf70faaa7c3dbeeab8e48","ref":"refs/heads/blampe/2985","pushedAt":"2024-05-09T20:58:32.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"blampe","name":"Bryce Lampe","path":"/blampe","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/848843?s=80&v=4"},"commit":{"message":"Merge branch 'master' of github.com:pulumi/pulumi-kubernetes into blampe/2985","shortMessageHtmlLink":"Merge branch 'master' of github.com:pulumi/pulumi-kubernetes into bla…"}},{"before":"df987d5826940a7e2db7773adee274eed836a776","after":null,"ref":"refs/heads/blampe/diff-panic","pushedAt":"2024-05-09T20:56:45.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"blampe","name":"Bryce Lampe","path":"/blampe","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/848843?s=80&v=4"}},{"before":"90910a65b5cb81c084a3b6051c99b1122b2a592c","after":"80d60f435ee36098f77b8df67b0bae0e430d15a7","ref":"refs/heads/master","pushedAt":"2024-05-09T20:56:43.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"blampe","name":"Bryce Lampe","path":"/blampe","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/848843?s=80&v=4"},"commit":{"message":"Fix a panic when diffing nil values against missing keys (#2987)\n\nUsers can run into a panic because we invoke `addPatchValueToDiff` like\r\nso:\r\n\r\n```go\r\npc.addPatchValueToDiff(append(path, k), v, old[k], newInput[k], oldInput[k], inArray)\r\n```\r\n\r\nThese are `map[string]any` types and will return `nil` when the `[k]`\r\nlookup returns `nil` _or_ when the key `k` is missing.\r\n\r\nThen in `addPatchValueToDiff` we assert:\r\n```go\r\ncontract.Assertf(v != nil || old != nil || oldInput != nil || newInput != nil)\r\n```\r\n\r\nbut we don't have enough information to distinguish the \"all values were\r\n`nil`\" case from the \"one value was `nil` and the other was missing\"\r\ncase. The assertion is only valid if all keys were present, hence we\r\npanic when a key is removed when it previously had a value of `nil`.\r\n\r\nThe easiest fix is to relax the assertion (b886cfb8d) -- allow the\r\nall-`nil` case since it can be valid. The downside is a poorer user\r\nexperience, because we don't have enough information to say whether the\r\nupdate is an add or a delete; we could call it an update (odd) or a\r\nno-op (lossy). The upside is it's a much smaller change with less risk.\r\n\r\nAlternatively, we can have a better user experience by making\r\n`addPatchValueToDiff` aware of whether keys were missing. This PR does\r\nthis by introducing a `missing` sentinel to distinguish from `nil`\r\nvalues. This is riskier, but fortunately our test coverage is\r\ncomprehensive.\r\n\r\nA failing unit test was added, along with another test to cover a small\r\nbit of logic we weren't testing.\r\n\r\nFixes https://github.com/pulumi/pulumi-kubernetes/issues/1970.","shortMessageHtmlLink":"Fix a panic when diffing nil values against missing keys (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2274138755\" data-permission-text=\"Title is private\" data-url=\"https://github.com/pulumi/pulumi-kubernetes/issues/2987\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/pulumi/pulumi-kubernetes/pull/2987/hovercard\" href=\"https://github.com/pulumi/pulumi-kubernetes/pull/2987\">#2987</a>)"}},{"before":"4eab5c475fea2bc0f1bfa9f2c0274f9f15c8a7c7","after":"df987d5826940a7e2db7773adee274eed836a776","ref":"refs/heads/blampe/diff-panic","pushedAt":"2024-05-09T20:25:24.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"blampe","name":"Bryce Lampe","path":"/blampe","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/848843?s=80&v=4"},"commit":{"message":"Don't need empty maps anymore","shortMessageHtmlLink":"Don't need empty maps anymore"}},{"before":"0ab11b50caad91123a6ddade3bf67fbca1b6e2c2","after":"4eab5c475fea2bc0f1bfa9f2c0274f9f15c8a7c7","ref":"refs/heads/blampe/diff-panic","pushedAt":"2024-05-09T17:55:28.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"blampe","name":"Bryce Lampe","path":"/blampe","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/848843?s=80&v=4"},"commit":{"message":"Merge branch 'master' into blampe/diff-panic","shortMessageHtmlLink":"Merge branch 'master' into blampe/diff-panic"}},{"before":"3c554849058b02fadf202d059bdb07b9076f4946","after":"b59b5d2a7e4a0cef8c2c709584cf77a16e184410","ref":"refs/heads/update-pulumi/9017454843-135","pushedAt":"2024-05-09T17:47:19.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"blampe","name":"Bryce Lampe","path":"/blampe","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/848843?s=80&v=4"},"commit":{"message":"Merge branch 'master' into update-pulumi/9017454843-135","shortMessageHtmlLink":"Merge branch 'master' into update-pulumi/9017454843-135"}},{"before":"09be004b18cd8d7cadc22395dbb8d75359a2a929","after":"90910a65b5cb81c084a3b6051c99b1122b2a592c","ref":"refs/heads/master","pushedAt":"2024-05-09T17:46:52.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"blampe","name":"Bryce Lampe","path":"/blampe","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/848843?s=80&v=4"},"commit":{"message":"Fix a couple tests not running on CI (#2982)\n\nI noticed as part of\r\nhttps://github.com/pulumi/pulumi-kubernetes/pull/2953 that the\r\n`tests/convert` and `tests/provider` directories aren't currently\r\ngetting exercised in CI, and as a result one of them is failing on\r\nmaster.\r\n\r\nThis PR moves `tests/provider` and `tests/convert` under `sdk/java`,\r\nwhich is currently executed in CI but doesn't contain any tests. We also\r\nfix the convert test along the way.\r\n\r\n\"sdk/java\" is admittedly an odd namespace to put these under, but our CI\r\ntargets don't give us much flexibility at the moment, and at the end of\r\nthe day it's just an arbitrary way of sharding things.","shortMessageHtmlLink":"Fix a couple tests not running on CI (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2270011709\" data-permission-text=\"Title is private\" data-url=\"https://github.com/pulumi/pulumi-kubernetes/issues/2982\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/pulumi/pulumi-kubernetes/pull/2982/hovercard\" href=\"https://github.com/pulumi/pulumi-kubernetes/pull/2982\">#2982</a>)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAES1AymQA","startCursor":null,"endCursor":null}},"title":"Activity · pulumi/pulumi-kubernetes"}