Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap tf-plguin-sdk functions which require strict int type with a conversion layer #1946

Open
VenelinMartinov opened this issue May 9, 2024 · 0 comments
Labels
kind/engineering Work that is not visible to an external user

Comments

@VenelinMartinov
Copy link
Contributor

What happened?

Following up on #1940 we found that the tf-plugin-sdk does type checking on integer inputs and asserts they are int. This breaks for int64 and other integer types.

We should add a layer in the bridge for interacting with this as it can cause issues.

See discussion in #1945

Example

.

Output of pulumi about

.

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@VenelinMartinov VenelinMartinov added the kind/engineering Work that is not visible to an external user label May 9, 2024
@VenelinMartinov VenelinMartinov changed the title Ensure all integers passed to the tf-plguin-sdk are of int type Wrap tf-plguin-sdk functions which require strict int type with a conversion layer May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user
Projects
None yet
Development

No branches or pull requests

1 participant