Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support upstream Required when used with DefaultFunc #1978

Open
guineveresaenger opened this issue May 15, 2024 · 0 comments
Open

Support upstream Required when used with DefaultFunc #1978

guineveresaenger opened this issue May 15, 2024 · 0 comments
Labels
kind/bug Some behavior is incorrect or out of spec

Comments

@guineveresaenger
Copy link
Contributor

guineveresaenger commented May 15, 2024

What happened?

Sometimes, the upstream schema sets Required on a resource field but also uses a DefaultFunc.

When this is the case, the pulumi field becomes Required, even though is behavior is not. The bridge should set the field in question to Optional on our end so that users don't have to pass nonsense values just so their code can run.

Example

See pulumi/pulumi-vault#509 - in question is the token field for pulumi-vault's config.

Output of pulumi about

n/a

Additional context

hashicorp/terraform-provider-vault#2237 (comment) explains the reasoning/history.

Docs for Required
Docs for DefaultFunc

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@guineveresaenger guineveresaenger added needs-triage Needs attention from the triage team kind/bug Some behavior is incorrect or out of spec labels May 15, 2024
@guineveresaenger guineveresaenger removed the needs-triage Needs attention from the triage team label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

No branches or pull requests

1 participant