Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for project level config key #378

Closed
AaronFriel opened this issue Oct 20, 2022 · 1 comment
Closed

Support for project level config key #378

AaronFriel opened this issue Oct 20, 2022 · 1 comment
Assignees
Labels
area/config area/docs Improvements or additions to documentation kind/enhancement Improvements or new features resolution/duplicate This issue is a duplicate of another issue

Comments

@AaronFriel
Copy link
Member

Pulumi has gained support for a project-wide config key (pulumi/pulumi#10832).

As YAML is a language host using the Go SDK, it should rely on on the Go SDK config package (GetConfig and IsConfigSecret) to derive configuration keys, and use the structure of the values to infer their types, leaving validation up to the engine. If that's not possible, we should should use shared code from the engine to parse the type and items fields.

As a consequence of using GetConfig, it may not be possible to statically analyze a Pulumi program absent a stack file to determine if the a key is defined. We may want an enhancement to the Go SDK's config package to allow us to query for the existence of a key or for static analysis to rely on the engine's parsing of the project file to be consistent.

As this would be a breaking change for configuration declarations; we should support the old key with a warning to avoid breaking users prior to GA.

@AaronFriel AaronFriel added area/docs Improvements or additions to documentation area/config kind/enhancement Improvements or new features labels Oct 20, 2022
@AaronFriel AaronFriel added this to the 0.80 milestone Oct 20, 2022
@AaronFriel AaronFriel mentioned this issue Oct 20, 2022
43 tasks
@AaronFriel AaronFriel added the resolution/duplicate This issue is a duplicate of another issue label Oct 20, 2022
@AaronFriel AaronFriel removed this from the 0.80 milestone Oct 20, 2022
@AaronFriel
Copy link
Member Author

Duplicate of #369, created from my to-do list as a lapse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config area/docs Improvements or additions to documentation kind/enhancement Improvements or new features resolution/duplicate This issue is a duplicate of another issue
Projects
None yet
Development

No branches or pull requests

2 participants