Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings and Errors should be prefixed with lowercase warning and error to match the CLI's output #467

Open
justinvp opened this issue Jul 29, 2023 · 0 comments
Labels
kind/enhancement Improvements or new features

Comments

@justinvp
Copy link
Member

I'm looking at adding a new error to YAML for invalid YAML programs and noticed that warnings from the CLI have a lowercase warning prefix, but warnings/errors from YAML have those prefixes in uppercase.

We should change these to be lowercase to match the CLI.

Diagnostics:
  pulumi:pulumi:Stack (yamloption-dev):
    warning: using pulumi-language-yaml from $PATH at /Users/justin/go/bin/pulumi-language-yaml
    warning: using pulumi-language-yaml from $PATH at /Users/justin/go/bin/pulumi-language-yaml

    Warning: Field 'version' does not exist on Object 'resources.my-bucket'
      on Pulumi.yaml line 10:
      10:     version: v5.41.0
    Existing fields are: 'options', 'get', 'type', 'properties', 'defaultProvider'
    Error: Required field 'type' is missing on resource "my-bucket"
      on Pulumi.yaml line 9:
       9:   my-bucket:

Resources:
    + 1 to create
Screen Shot 2023-07-28 at 5 20 36 PM
@justinvp justinvp added the kind/enhancement Improvements or new features label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

1 participant