-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing test on master: --- FAIL: TestGenerateProgram/regress-11176 #13644
Comments
Okay, so here's what's happening: If anyone encounters this in their code, they should run:
For the test, we're going to attempt to fix the dependencies we control that have this conflict. Refs: googleapis/go-genproto#1015 |
Details are documented in pulumi/pulumi#13644 (comment), but in short: The old version of google.golang.org/genproto provides google.golang.org/genproto/googleapis/rpc as a subpackage, and this conflicts with the independent submodule google.golang.org/genproto/googleapis/rpc. This means that a fresh new Go program that imports `pulumi` and `pulumi-awsx` will break with an error like: ``` google.golang.org/genproto/googleapis/rpc/errdetails: ambiguous import: found package google.golang.org/genproto/googleapis/rpc/errdetails in multiple modules: google.golang.org/genproto v0.0.0-20230410155749-daa745c078e1 ($GOPATH/pkg/mod/google.golang.org/genproto@v0.0.0-20230410155749-daa745c078e1/googleapis/rpc/errdetails) google.golang.org/genproto/googleapis/rpc v0.0.0-20230706204954-ccb25ca9f130 ($GOPATH/pkg/mod/google.golang.org/genproto/googleapis/rpc@v0.0.0-20230706204954-ccb25ca9f130/errdetails) ``` Refs pulumi/pulumi#13644
**Do not merge** Pins Go codegen tests to pulumi/pulumi-awsx#1066 to verify that this would indeed fix #13644. Refs #13644
Details are documented in pulumi/pulumi#13644 (comment), but in short: The old version of google.golang.org/genproto provides google.golang.org/genproto/googleapis/rpc as a subpackage, and this conflicts with the independent submodule google.golang.org/genproto/googleapis/rpc. This means that a fresh new Go program that imports `pulumi` and `pulumi-awsx` will break with an error like: ``` google.golang.org/genproto/googleapis/rpc/errdetails: ambiguous import: found package google.golang.org/genproto/googleapis/rpc/errdetails in multiple modules: google.golang.org/genproto v0.0.0-20230410155749-daa745c078e1 ($GOPATH/pkg/mod/google.golang.org/genproto@v0.0.0-20230410155749-daa745c078e1/googleapis/rpc/errdetails) google.golang.org/genproto/googleapis/rpc v0.0.0-20230706204954-ccb25ca9f130 ($GOPATH/pkg/mod/google.golang.org/genproto/googleapis/rpc@v0.0.0-20230706204954-ccb25ca9f130/errdetails) ``` Refs pulumi/pulumi#13644
Details are documented in pulumi/pulumi#13644 (comment), but in short: The old version of google.golang.org/genproto provides google.golang.org/genproto/googleapis/rpc as a subpackage, and this conflicts with the independent submodule google.golang.org/genproto/googleapis/rpc. This means that a fresh new Go program that imports `pulumi` and `pulumi-awsx` will break with an error like: ``` google.golang.org/genproto/googleapis/rpc/errdetails: ambiguous import: found package google.golang.org/genproto/googleapis/rpc/errdetails in multiple modules: google.golang.org/genproto v0.0.0-20230410155749-daa745c078e1 ($GOPATH/pkg/mod/google.golang.org/genproto@v0.0.0-20230410155749-daa745c078e1/googleapis/rpc/errdetails) google.golang.org/genproto/googleapis/rpc v0.0.0-20230706204954-ccb25ca9f130 ($GOPATH/pkg/mod/google.golang.org/genproto/googleapis/rpc@v0.0.0-20230706204954-ccb25ca9f130/errdetails) ``` Refs pulumi/pulumi#13644
pulumi/pulumi-awsx#1066 has been merged. We'll need an awsx release. |
regress-11176 is currently broken because it imports awsx which, without pulumi/pulumi-awsx#1066 released pulls in an old version of google.golang.org/genproto, and that conflicts with the newer version. Details in #13644 (comment) This change disables the test so that tests on master aren't red. Refs #13644
13649: test(codegen): Disable regress-11176 r=abhinav a=abhinav regress-11176 is currently broken because it imports awsx which, without pulumi/pulumi-awsx#1066 released pulls in an old version of google.golang.org/genproto, and that conflicts with the newer version. Details in #13644 (comment) This change disables the test so that tests on master aren't red. Refs #13644 Co-authored-by: Abhinav Gupta <abhinav@pulumi.com>
13649: test(codegen): Disable regress-11176 r=abhinav a=abhinav regress-11176 is currently broken because it imports awsx which, without pulumi/pulumi-awsx#1066 released pulls in an old version of google.golang.org/genproto, and that conflicts with the newer version. Details in #13644 (comment) This change disables the test so that tests on master aren't red. Refs #13644 Co-authored-by: Abhinav Gupta <abhinav@pulumi.com>
13649: test(codegen): Disable regress-11176 r=abhinav a=abhinav regress-11176 is currently broken because it imports awsx which, without pulumi/pulumi-awsx#1066 released pulls in an old version of google.golang.org/genproto, and that conflicts with the newer version. Details in #13644 (comment) This change disables the test so that tests on master aren't red. Refs #13644 Co-authored-by: Abhinav Gupta <abhinav@pulumi.com>
Unassigning to test out issue-label-bot^. |
13652: Revert "test(codegen): Disable regress-11176" r=abhinav a=abhinav Revert the test disabled in #13649 to unblock master builds now that pulumi-awsx has been released with pulumi/pulumi-awsx#1066. This reverts commit e270756. Resolves #13644 Co-authored-by: Abhinav Gupta <abhinav@pulumi.com>
Cannot close issue:
Please fix these problems and try again. |
What happened?
Looks like one of the test started failing, blocking PRs.
Expected Behavior
Tests are green on master.
Steps to reproduce
Logs give:
Output of
pulumi about
$ go version
go version go1.20.1 darwin/arm64
Additional context
Also failing in CI eg on the #13592 PR but I don't think it is related to the changes in the PR.
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
The text was updated successfully, but these errors were encountered: