Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a typed Deployment interface to the Automation API for Node #16142

Open
zbuchheit opened this issue May 7, 2024 · 1 comment
Open

Add a typed Deployment interface to the Automation API for Node #16142

zbuchheit opened this issue May 7, 2024 · 1 comment
Labels
area/automation-api customer/feedback Feedback from customers customer/lighthouse Lighthouse customer bugs kind/enhancement Improvements or new features language/javascript

Comments

@zbuchheit
Copy link

zbuchheit commented May 7, 2024

Hello!

  • Vote on this issue by adding a 馃憤 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

In the pulumi/pulumi sdk in GO we have DeploymentV3 but it doesn't appear this is exposed in our node sdk. I can see a deployment used in the automation workspace.ts file but it is of type any. It would be helpful to add typing to this in the package.

Affected area/feature

Automation API, Node

@zbuchheit zbuchheit added kind/enhancement Improvements or new features language/javascript needs-triage Needs attention from the triage team area/automation-api customer/feedback Feedback from customers customer/lighthouse Lighthouse customer bugs labels May 7, 2024
@justinvp justinvp removed the needs-triage Needs attention from the triage team label May 7, 2024
@Frassle
Copy link
Member

Frassle commented May 8, 2024

The Go SDK is privileged because it can share engine code.
Manually re-writing all the deployment types and keeping them in-sync across all the languages is going to be even more strain on an already strained area of the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/automation-api customer/feedback Feedback from customers customer/lighthouse Lighthouse customer bugs kind/enhancement Improvements or new features language/javascript
Projects
None yet
Development

No branches or pull requests

3 participants