language_test: allow more characters in the log before truncating #16213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We initially introduced this limit for log messages in #16117. However I've since realized that these log messages also include useful stacktraces (when the program being tested throws an exception), which are a bit longer. The intention here is really to avoid *really* long messages, so increase the maximum message size a little to still avoid those, but allow us to see more of the stacktrace that should hopefully be useful for debugging. The number is mostly still based on a guesstimate of what's useful, but it's easy to tweak if we need to tweak it further.
tgummerer
added
the
impact/no-changelog-required
Changelog[uncommitted] (2024-05-16) |
lunaris
approved these changes
May 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
We might need a postmortem about this 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We initially introduced this limit for log messages in #16117. However I've since realized that these log messages also include useful stacktraces (when the program being tested throws an exception), which are a bit longer.
The intention here is really to avoid really long messages, so increase the maximum message size a little to still avoid those, but allow us to see more of the stacktrace that should hopefully be useful for debugging.
The number is mostly still based on a guesstimate of what's useful, but it's easy to tweak if we need to tweak it further.