Panic when ec2.LookupAmiOutput finds no matching results

[t0yv0]

Hello!

• Vote on this issue by adding a 👍 reaction
• To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already)

Issue details

ec2.LookupAmiOutput panics when the user-specified filters result in no AMIs being found.

package main

import (
	"github.com/pulumi/pulumi-aws/sdk/v4/go/aws/ec2"
	"github.com/pulumi/pulumi/sdk/v3/go/pulumi"
)

func main() {
	pulumi.Run(func(ctx *pulumi.Context) error {
		res := ec2.LookupAmiOutput(ctx, ec2.LookupAmiOutputArgs{
			Filters: ec2.GetAmiFilterArray{
				ec2.GetAmiFilterArgs{
					Name: pulumi.String("name"),
					// use "Cloud9AmazonLinux2-*" to get a valid result
					Values: pulumi.StringArray{pulumi.String("Cloud9AmazonLinux3-*")},
				},
			},
			MostRecent: pulumi.Bool(true),
			Owners:     pulumi.StringArray{pulumi.String("amazon")},
		})

		ctx.Export("arn", res.Arn())
		return nil
	})
}

Steps to reproduce

Expected: recoverable error or empty result
Actual: panic

Filing it here rather than in pulumi/pulumi-aws as this might be an issue with handling errors in the newly introduced $fnOutput helper feature, the older plain version of the invoke LookupAmi is better behaved here.

[dixler]

I was able to repro this error on github.com/pulumi/pulumi-aws/sdk/v4/go/aws/ec2 so I should be able to identify the issue.

This appears fixed on the latest v5 of the aws provider. (github.com/pulumi/pulumi-aws/sdk/v5/go/aws/ec2)

[dixler]

This appears to be fixed by
https://github.com/pulumi/pulumi-aws/blame/e4bbada0d3a3549c240b9bead5eaec5b1a924e40/sdk/go/aws/ec2/getAmi.go#L204-L208

Duplicate of pulumi/pulumi-aws#1872
Fixed by #9274