Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect diff rendering for compound secret values #9362

Closed
pgavlin opened this issue Apr 7, 2022 · 1 comment
Closed

Incorrect diff rendering for compound secret values #9362

pgavlin opened this issue Apr 7, 2022 · 1 comment
Assignees
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Milestone

Comments

@pgavlin
Copy link
Member

pgavlin commented Apr 7, 2022

When the diff for a resource references nested properties of a compound secret value, the nested properties are not rendered properly. For example, in the diff below, the service and apiVersions properties should not be empty objects, and should instead be displayed as changes from [secret] => [secret] (as the values are, after all, secret).

        ~ kubernetes:admissionregistration.k8s.io/v1:ValidatingWebhookConfiguration: (update)
            [id=aws-load-balancer-controller-validating-webhook-configuration-4wkyh883]
            [urn=urn:pulumi:mm-3f33882c::aws-eks-webapp-ingress-typescript::cloud:x/aws/eks:LoadBalancerController$kubernetes:admissionregistration.k8s.io/v1:ValidatingWebhookConfiguration::aws-load-balancer-controller-validating-webhook-configuration]
            [provider=urn:pulumi:mm-3f33882c::aws-eks-webapp-ingress-typescript::pulumi:providers:kubernetes::k8s-provider::0f395882-5060-434b-84a1-98fce94a4741]
          ~ webhooks: [
                [0]: <null>
              ~ [1]: {
                      ~ clientConfig: {
                          ~ service: {
                            }
                        }
                      ~ rules       : [
                          ~ [0]: {
                                  ~ apiVersions: [
                                    ]
                                }
                        ]
                    }
            ]
@pgavlin pgavlin added the kind/bug Some behavior is incorrect or out of spec label Apr 7, 2022
@pgavlin pgavlin self-assigned this Apr 7, 2022
@pgavlin
Copy link
Member Author

pgavlin commented Apr 7, 2022

Fixed by #9351.

@pgavlin pgavlin added the resolution/fixed This issue was fixed label Apr 7, 2022
@pgavlin pgavlin closed this as completed Apr 7, 2022
@mikhailshilkov mikhailshilkov added this to the 0.71 milestone Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

2 participants