pulumi new leaves orphan processes with open files

[AaronFriel]

This bug may cause Windows users to be unable to save/edit/delete templates until the orphan processes are stopped.

See this pull request in pulumi/templates:

• Fix CI out of memory conditions on Windows templates#263

The most recent run failed failed on cleaning up directories, even when taking every step to postpone cleanup until after all subtests have completed and mitigating an out of memory with Windows runners. The raw logs reveal the reason why both began after merging #9294:

2022-04-20T04:04:51.7926136Z Cleaning up orphan processes
2022-04-20T04:04:51.9225675Z Terminate orphan process: pid (4468) (pulumi-language-python)
2022-04-20T04:04:51.9968964Z Terminate orphan process: pid (216) (pulumi-language-nodejs)
2022-04-20T04:04:52.0610929Z Terminate orphan process: pid (4256) (pulumi-language-dotnet)
2022-04-20T04:04:52.1107457Z Terminate orphan process: pid (4088) (pulumi-language-dotnet)
2022-04-20T04:04:52.1829793Z Terminate orphan process: pid (3100) (pulumi-language-nodejs)
2022-04-20T04:04:52.2425265Z Terminate orphan process: pid (5644) (pulumi-language-python)
2022-04-20T04:04:52.3180761Z Terminate orphan process: pid (1128) (pulumi-language-nodejs)
2022-04-20T04:04:52.3771765Z Terminate orphan process: pid (5036) (pulumi-language-python)
2022-04-20T04:04:52.4105189Z Terminate orphan process: pid (3392) (pulumi-language-nodejs)
2022-04-20T04:04:52.4800830Z Terminate orphan process: pid (2576) (pulumi-language-go)
2022-04-20T04:04:52.5650033Z Terminate orphan process: pid (4020) (pulumi-language-nodejs)
2022-04-20T04:04:52.6288504Z Terminate orphan process: pid (1320) (pulumi-language-nodejs)
2022-04-20T04:04:52.7066419Z Terminate orphan process: pid (2188) (pulumi-language-nodejs)
2022-04-20T04:04:52.7787058Z Terminate orphan process: pid (4192) (pulumi-language-python)
2022-04-20T04:04:52.8734529Z Terminate orphan process: pid (1136) (pulumi-language-go)
2022-04-20T04:04:52.9208724Z Terminate orphan process: pid (3892) (pulumi-language-dotnet)
2022-04-20T04:04:53.0097520Z Terminate orphan process: pid (4716) (pulumi-language-go)
2022-04-20T04:04:53.2458405Z Terminate orphan process: pid (5184) (dotnet)
2022-04-20T04:04:53.3414468Z Terminate orphan process: pid (2568) (pulumi-language-dotnet)
2022-04-20T04:04:53.4015007Z Terminate orphan process: pid (5060) (pulumi-language-nodejs)
2022-04-20T04:04:53.4511042Z Terminate orphan process: pid (4544) (pulumi-language-python)
2022-04-20T04:04:53.4984144Z Terminate orphan process: pid (6528) (pulumi-language-nodejs)
2022-04-20T04:04:53.5465053Z Terminate orphan process: pid (5596) (pulumi-language-go)
2022-04-20T04:04:53.5812255Z Terminate orphan process: pid (6188) (pulumi-language-dotnet)
2022-04-20T04:04:53.6257550Z Terminate orphan process: pid (1824) (pulumi-language-dotnet)
2022-04-20T04:04:53.6928400Z Terminate orphan process: pid (4120) (pulumi-language-dotnet)
2022-04-20T04:04:53.7423437Z Terminate orphan process: pid (6556) (pulumi-language-dotnet)
2022-04-20T04:04:53.8023759Z Terminate orphan process: pid (1120) (pulumi-language-nodejs)
2022-04-20T04:04:53.8500342Z Terminate orphan process: pid (4448) (pulumi-language-go)
2022-04-20T04:04:53.9003753Z Terminate orphan process: pid (6544) (pulumi-language-dotnet)
2022-04-20T04:04:53.9224257Z Terminate orphan process: pid (6520) (pulumi-language-dotnet)
2022-04-20T04:04:53.9706994Z Terminate orphan process: pid (6356) (pulumi-language-dotnet)
2022-04-20T04:04:53.9876744Z Terminate orphan process: pid (6648) (pulumi-language-nodejs)
2022-04-20T04:04:53.9967508Z Terminate orphan process: pid (6244) (pulumi-language-python)
2022-04-20T04:04:54.0071970Z Terminate orphan process: pid (3028) (pulumi-language-nodejs)
2022-04-20T04:04:54.0160760Z Terminate orphan process: pid (6632) (pulumi-language-go)
2022-04-20T04:04:54.0283068Z Terminate orphan process: pid (6248) (pulumi-language-dotnet)
2022-04-20T04:04:54.0369475Z Terminate orphan process: pid (5196) (pulumi-language-dotnet)
2022-04-20T04:04:54.0469780Z Terminate orphan process: pid (3572) (pulumi-language-dotnet)
2022-04-20T04:04:54.0601415Z Terminate orphan process: pid (6824) (pulumi-language-nodejs)
2022-04-20T04:04:54.0688023Z Terminate orphan process: pid (6156) (pulumi-language-python)
2022-04-20T04:04:54.0774962Z Terminate orphan process: pid (1640) (pulumi-language-dotnet)
2022-04-20T04:04:54.0862691Z Terminate orphan process: pid (5752) (pulumi-language-nodejs)
2022-04-20T04:04:54.0948755Z Terminate orphan process: pid (3508) (pulumi-language-python)
2022-04-20T04:04:54.1037514Z Terminate orphan process: pid (6916) (pulumi-language-nodejs)
2022-04-20T04:04:54.1262043Z Terminate orphan process: pid (7676) (pulumi-language-go)
2022-04-20T04:04:54.1349872Z Terminate orphan process: pid (8008) (pulumi-language-dotnet)
2022-04-20T04:04:54.1435395Z Terminate orphan process: pid (4764) (pulumi-language-dotnet)
2022-04-20T04:04:54.1614580Z Terminate orphan process: pid (7984) (pulumi-language-nodejs)
2022-04-20T04:04:54.1796783Z Terminate orphan process: pid (5716) (pulumi-language-go)
2022-04-20T04:04:54.1895074Z Terminate orphan process: pid (8044) (pulumi-language-dotnet)

[stack72]

This feels like a regression right ?

[AaronFriel]

Yeah, definitely. Going to try pulumi new on my Windows machine in a moment.

[Frassle]

Wonder if new is just missing a call to Host shutdown?

[AaronFriel]

@stack72 I wouldn't consider this a P1, because the only file handle opened is that of the directory, none of the files in the dir are locked by the language plugin. Tested all aws-$lang and azure-$lang templates.

Screenshot of Sysinternals Process Explorer, showing an orphan "pulumi-language-nodejs.exe" process with an open file handle for the directory of the Pulumi project, no other file handles are relevant: