Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider-namespace configuration values should not have a type #477

Closed
scottslowe opened this issue Dec 9, 2022 · 2 comments · Fixed by #478
Closed

Provider-namespace configuration values should not have a type #477

scottslowe opened this issue Dec 9, 2022 · 2 comments · Fixed by #478
Assignees
Labels
emergent An issue that was added to the current milestone after planning impact/regression Something that used to work, but is now broken impact/usability Something that impacts users' ability to use the product easily and intuitively kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed size/S Estimated effort to complete (1-2 days).
Milestone

Comments

@scottslowe
Copy link
Contributor

What happened?

Architecture templates that leverage provider-namespace configuration values (like aws:region or gcp:project) are broken following the implementation of hierarchical configuration (as implemented via pulumi/pulumi#10832). This appears to be due to the fact that the architecture templates included a type field for provider-namespace configuration values, and that field is no longer supported/allowed.

Steps to reproduce

  1. Run pulumi new kubernetes-gcp-yaml.
  2. Observe the error that results:
error: template 'kubernetes-gcp-yaml' is currently broken: could not unmarshal '/Users/slowe/.pulumi/templates/kubernetes-gcp-yaml/Pulumi.yaml': Configuration key 'gcp:project' is not namespaced by the project and should not define a type

Expected Behavior

It's expected that pulumi new will work and create a new project as expected.

Actual Behavior

The pulumi new command fails with an error, and there is no obvious workaround for users.

Output of pulumi about

CLI
Version      3.49.0
Go Version   go1.19.4
Go Compiler  gc

Host
OS       darwin
Version  12.6.1
Arch     arm64

Backend
Name           pulumi.com
URL            https://app.pulumi.com/scottslowe
User           scottslowe
Organizations  scottslowe

Pulumi locates its logs in /var/folders/c_/1pdwtg4j5zx4dvx5t6qp9v180000gn/T/ by default

Additional context

Confirmed on two different macOS systems, one running Pulumi 3.49.0 (that's the output of pulumi about shown above) and another system running Pulumi 3.45.0.

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@scottslowe scottslowe added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team impact/usability Something that impacts users' ability to use the product easily and intuitively emergent An issue that was added to the current milestone after planning impact/regression Something that used to work, but is now broken and removed needs-triage Needs attention from the triage team labels Dec 9, 2022
@scottslowe scottslowe self-assigned this Dec 9, 2022
@scottslowe scottslowe added this to the 0.82 milestone Dec 9, 2022
@scottslowe
Copy link
Contributor Author

#478 will fix the problem and close the issue, currently awaiting review and tests to complete

@scottslowe
Copy link
Contributor Author

Just waiting on tests to finish on #478 before merging (which will complete/fix/close this).

@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Dec 13, 2022
@cnunciato cnunciato added the size/S Estimated effort to complete (1-2 days). label Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emergent An issue that was added to the current milestone after planning impact/regression Something that used to work, but is now broken impact/usability Something that impacts users' ability to use the product easily and intuitively kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed size/S Estimated effort to complete (1-2 days).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants