feat(chromium): roll Chromium to r856583 (#6927)

* feat(chromium): roll Chromium to r856583 This corresponds to Chromium 90.0.4427.0 This roll includes: - Add sourceScheme, sourcePort, and sameParty to DevTools backend (https://crbug.com/1170548, https://crbug.com/1142606)
puppeteer · Feb 26, 2021 · 0c688bd · 0c688bd
1 parent 05c08e7
commit 0c688bd
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -54,7 +54,7 @@
   "license": "Apache-2.0",
   "dependencies": {
     "debug": "^4.1.0",
-    "devtools-protocol": "0.0.847576",
+    "devtools-protocol": "0.0.854822",
     "extract-zip": "^2.0.0",
     "https-proxy-agent": "^5.0.0",
     "node-fetch": "^2.6.1",

diff --git a/src/revisions.ts b/src/revisions.ts
@@ -20,6 +20,6 @@ type Revisions = Readonly<{
 }>;
 
 export const PUPPETEER_REVISIONS: Revisions = {
-  chromium: '848005',
+  chromium: '856583',
   firefox: 'latest',
 };
diff --git a/test/cookies.spec.ts b/test/cookies.spec.ts
@@ -49,6 +49,8 @@ describe('Cookie specs', () => {
           httpOnly: false,
           secure: false,
           session: true,
+          sourcePort: 8907,
+          sourceScheme: 'NonSecure',
         },
       ]);
     });
@@ -106,6 +108,8 @@ describe('Cookie specs', () => {
           httpOnly: false,
           secure: false,
           session: true,
+          sourcePort: 8907,
+          sourceScheme: 'NonSecure',
         },
         {
           name: 'username',
@@ -118,6 +122,8 @@ describe('Cookie specs', () => {
           httpOnly: false,
           secure: false,
           session: true,
+          sourcePort: 8907,
+          sourceScheme: 'NonSecure',
         },
       ]);
     });
@@ -154,6 +160,8 @@ describe('Cookie specs', () => {
           httpOnly: false,
           secure: true,
           session: true,
+          sourcePort: 443,
+          sourceScheme: 'Secure',
         },
         {
           name: 'doggo',
@@ -166,6 +174,8 @@ describe('Cookie specs', () => {
           httpOnly: false,
           secure: true,
           session: true,
+          sourcePort: 443,
+          sourceScheme: 'Secure',
         },
       ]);
     });
@@ -259,6 +269,8 @@ describe('Cookie specs', () => {
           httpOnly: false,
           secure: false,
           session: true,
+          sourcePort: 80,
+          sourceScheme: 'NonSecure',
         },
       ]);
     });
@@ -283,6 +295,8 @@ describe('Cookie specs', () => {
           httpOnly: false,
           secure: false,
           session: true,
+          sourcePort: 80,
+          sourceScheme: 'NonSecure',
         },
       ]);
       expect(await page.evaluate('document.cookie')).toBe('gridcookie=GRID');
@@ -389,6 +403,8 @@ describe('Cookie specs', () => {
           httpOnly: false,
           secure: true,
           session: true,
+          sourcePort: 443,
+          sourceScheme: 'Secure',
         },
       ]);
     });
@@ -428,6 +444,8 @@ describe('Cookie specs', () => {
           httpOnly: false,
           secure: false,
           session: true,
+          sourcePort: 80,
+          sourceScheme: 'NonSecure',
         },
       ]);
 
@@ -443,6 +461,8 @@ describe('Cookie specs', () => {
           httpOnly: false,
           secure: false,
           session: true,
+          sourcePort: 80,
+          sourceScheme: 'NonSecure',
         },
       ]);
     });
@@ -496,6 +516,8 @@ describe('Cookie specs', () => {
               sameSite: 'None',
               secure: true,
               session: true,
+              sourcePort: 443,
+              sourceScheme: 'Secure',
             },
           ]);
         } finally {

diff --git a/test/defaultbrowsercontext.spec.ts b/test/defaultbrowsercontext.spec.ts
@@ -43,6 +43,8 @@ describe('DefaultBrowserContext', function () {
         httpOnly: false,
         secure: false,
         session: true,
+        sourcePort: 8907,
+        sourceScheme: 'NonSecure',
       },
     ]);
   });
@@ -69,6 +71,8 @@ describe('DefaultBrowserContext', function () {
         httpOnly: false,
         secure: false,
         session: true,
+        sourcePort: 80,
+        sourceScheme: 'NonSecure',
       },
     ]);
   });
@@ -101,6 +105,8 @@ describe('DefaultBrowserContext', function () {
         httpOnly: false,
         secure: false,
         session: true,
+        sourcePort: 80,
+        sourceScheme: 'NonSecure',
       },
     ]);
   });