Skip to content

Commit

Permalink
fix(page): page.createIsolatedWorld error catching has been added (#7848
Browse files Browse the repository at this point in the history
)

Co-authored-by: DimaShustal <dzmitry.shustal@gmail.com>
Co-authored-by: Alex Rudenko <OrKoN@users.noreply.github.com>
  • Loading branch information
3 people committed Mar 3, 2022
1 parent 608d944 commit 309e8b8
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions src/common/FrameManager.ts
Expand Up @@ -16,7 +16,7 @@

import { EventEmitter } from './EventEmitter.js';
import { assert } from './assert.js';
import { helper } from './helper.js';
import { helper, debugError } from './helper.js';
import { ExecutionContext, EVALUATION_SCRIPT_URL } from './ExecutionContext.js';
import {
LifecycleWatcher,
Expand Down Expand Up @@ -393,11 +393,13 @@ export class FrameManager extends EventEmitter {
this.frames()
.filter((frame) => frame._client === session)
.map((frame) =>
session.send('Page.createIsolatedWorld', {
frameId: frame._id,
worldName: name,
grantUniveralAccess: true,
})
session
.send('Page.createIsolatedWorld', {
frameId: frame._id,
worldName: name,
grantUniveralAccess: true,
})
.catch(debugError)
)
);
}
Expand Down

0 comments on commit 309e8b8

Please sign in to comment.