From 309e8b80da0519327bc37b44a3ebb6f2e2d357a7 Mon Sep 17 00:00:00 2001 From: Dima Date: Wed, 2 Mar 2022 15:03:44 +0300 Subject: [PATCH] fix(page): page.createIsolatedWorld error catching has been added (#7848) Co-authored-by: DimaShustal Co-authored-by: Alex Rudenko --- src/common/FrameManager.ts | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/common/FrameManager.ts b/src/common/FrameManager.ts index 2b5aa7ddd5670..7a39864894ee3 100644 --- a/src/common/FrameManager.ts +++ b/src/common/FrameManager.ts @@ -16,7 +16,7 @@ import { EventEmitter } from './EventEmitter.js'; import { assert } from './assert.js'; -import { helper } from './helper.js'; +import { helper, debugError } from './helper.js'; import { ExecutionContext, EVALUATION_SCRIPT_URL } from './ExecutionContext.js'; import { LifecycleWatcher, @@ -393,11 +393,13 @@ export class FrameManager extends EventEmitter { this.frames() .filter((frame) => frame._client === session) .map((frame) => - session.send('Page.createIsolatedWorld', { - frameId: frame._id, - worldName: name, - grantUniveralAccess: true, - }) + session + .send('Page.createIsolatedWorld', { + frameId: frame._id, + worldName: name, + grantUniveralAccess: true, + }) + .catch(debugError) ) ); }