Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
fix: allow getting a frame from an elementhandle (#8875)
Libraries like pptr-testing-library and expect-puppeteer seem to
rely on it.
  • Loading branch information
OrKoN committed Aug 31, 2022
1 parent 3499e12 commit 3732757
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 3 deletions.
13 changes: 13 additions & 0 deletions docs/api/puppeteer.elementhandle.frame.md
@@ -0,0 +1,13 @@
---
sidebar_label: ElementHandle.frame
---

# ElementHandle.frame property

**Signature:**

```typescript
class ElementHandle {
get frame(): Frame;
}
```
6 changes: 6 additions & 0 deletions docs/api/puppeteer.elementhandle.md
Expand Up @@ -39,6 +39,12 @@ If you're using TypeScript, ElementHandle takes a generic argument that denotes
The constructor for this class is marked as internal. Third-party code should not call the constructor directly or create subclasses that extend the `ElementHandle` class.
## Properties
| Property | Modifiers | Type | Description |
| ------------------------------------------- | --------------------- | ----------------------------- | ----------- |
| [frame](./puppeteer.elementhandle.frame.md) | <code>readonly</code> | [Frame](./puppeteer.frame.md) | |
## Methods
| Method | Modifiers | Description |
Expand Down
3 changes: 0 additions & 3 deletions src/common/ElementHandle.ts
Expand Up @@ -88,9 +88,6 @@ export class ElementHandle<
return this.#frame.page();
}

/**
* @internal
*/
get frame(): Frame {
return this.#frame;
}
Expand Down

0 comments on commit 3732757

Please sign in to comment.