Skip to content

Commit

Permalink
chore: small CI tidy ups (#5751)
Browse files Browse the repository at this point in the history
* Increased the timeout to a flat 25 second for every build because we
still see the odd, non-reproducible timeout on a variety of machines.
* Removed an extraneous `npm run test-install` which meant we did that
check twice on each CI run.
  • Loading branch information
jackfranklin committed Apr 27, 2020
1 parent 5e2a029 commit 3911836
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
1 change: 0 additions & 1 deletion .travis.yml
Expand Up @@ -35,7 +35,6 @@ jobs:
before_install:
- PUPPETEER_PRODUCT=firefox npm install
script:
- npm run test-install
- npm run coverage

# This bot runs all the extra checks that aren't the main Puppeteer unit tests
Expand Down
9 changes: 1 addition & 8 deletions mocha-config/puppeteer-unit-tests.js
Expand Up @@ -14,18 +14,11 @@
* limitations under the License.
*/

const os = require('os');
const base = require('./base');

const longerTimeoutRequired = process.env.PUPPETEER_PRODUCT === 'firefox' || os.platform() === 'win32';

const timeout = longerTimeoutRequired ? 25 * 1000 : 10 * 1000;

console.log('Mocha config: Timeout set to', timeout / 1000, 'seconds');

module.exports = {
...base,
file: ['./test/mocha-utils.js'],
spec: 'test/*.spec.js',
timeout,
timeout: 25 * 1000,
};

0 comments on commit 3911836

Please sign in to comment.