Skip to content

Commit

Permalink
chore: extract Request and Response into its own module (#5861)
Browse files Browse the repository at this point in the history
* chore: extract `Request` and `Response` into its own module
  • Loading branch information
christian-bromann committed May 13, 2020
1 parent b510c35 commit 39f1b13
Show file tree
Hide file tree
Showing 7 changed files with 473 additions and 431 deletions.
3 changes: 2 additions & 1 deletion src/FrameManager.ts
Expand Up @@ -20,12 +20,13 @@ import { Events } from './Events';
import { ExecutionContext, EVALUATION_SCRIPT_URL } from './ExecutionContext';
import { LifecycleWatcher, PuppeteerLifeCycleEvent } from './LifecycleWatcher';
import { DOMWorld, WaitForSelectorOptions } from './DOMWorld';
import { NetworkManager, Response } from './NetworkManager';
import { NetworkManager } from './NetworkManager';
import { TimeoutSettings } from './TimeoutSettings';
import { CDPSession } from './Connection';
import { JSHandle, ElementHandle } from './JSHandle';
import { MouseButtonInput } from './Input';
import { Page } from './Page';
import { Response } from './Response';

const UTILITY_WORLD_NAME = '__puppeteer_utility_world__';

Expand Down
3 changes: 2 additions & 1 deletion src/LifecycleWatcher.ts
Expand Up @@ -18,7 +18,8 @@ import { helper, assert, PuppeteerEventListener } from './helper';
import { Events } from './Events';
import { TimeoutError } from './Errors';
import { FrameManager, Frame } from './FrameManager';
import { Request, Response } from './NetworkManager';
import { Request } from './Request';
import { Response } from './Response';

export type PuppeteerLifeCycleEvent =
| 'load'
Expand Down

0 comments on commit 39f1b13

Please sign in to comment.