From 541281b9f32881d0a7b12973c3aded57b7f0b95d Mon Sep 17 00:00:00 2001 From: Mathias Bynens Date: Thu, 30 Apr 2020 12:58:51 +0200 Subject: [PATCH] chore: fix doclint issues (#5784) --- CONTRIBUTING.md | 1 + utils/doclint/check_public_api/JSBuilder.js | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2ec11d923d51b..77200b8a23a64 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -4,6 +4,7 @@ * [Getting Code](#getting-code) * [Code reviews](#code-reviews) * [Code Style](#code-style) + * [TypeScript guidelines](#typescript-guidelines) * [API guidelines](#api-guidelines) * [Commit Messages](#commit-messages) * [Writing Documentation](#writing-documentation) diff --git a/utils/doclint/check_public_api/JSBuilder.js b/utils/doclint/check_public_api/JSBuilder.js index acf6d983f6f04..93d2ac579cdfa 100644 --- a/utils/doclint/check_public_api/JSBuilder.js +++ b/utils/doclint/check_public_api/JSBuilder.js @@ -189,7 +189,7 @@ function checkSources(sources) { * @return {boolean} */ function symbolHasPrivateModifier(symbol) { - const modifiers = symbol.valueDeclaration.modifiers || []; + const modifiers = symbol.valueDeclaration && symbol.valueDeclaration.modifiers || []; return modifiers.some(modifier => modifier.kind === ts.SyntaxKind.PrivateKeyword); }