From 5b792de7a97611441777d1ac99cb95516301d7dc Mon Sep 17 00:00:00 2001 From: Jan Scheffler Date: Wed, 27 Oct 2021 15:49:27 +0200 Subject: [PATCH] fix: prevent Target closed errors on streams (#7728) This change prevents Target closed errors when reading streams which were caused by ending the stream before IO.close returns. --- src/common/helper.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/helper.ts b/src/common/helper.ts index a0f4e627ea9ad..098de5a520de4 100644 --- a/src/common/helper.ts +++ b/src/common/helper.ts @@ -364,9 +364,9 @@ async function getReadableFromProtocolStream( const response = await client.send('IO.read', { handle, size }); this.push(response.data, response.base64Encoded ? 'base64' : undefined); if (response.eof) { - this.push(null); eof = true; await client.send('IO.close', { handle }); + this.push(null); } }, });