feat(firefox): support "referer" option in Page.goto (#4000)

puppeteer · Feb 13, 2019 · 670d758 · 670d758
1 parent fbf3643
commit 670d758
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/experimental/puppeteer-firefox/lib/FrameManager.js b/experimental/puppeteer-firefox/lib/FrameManager.js
@@ -193,10 +193,12 @@ class Frame {
     const {
       timeout = this._timeoutSettings.navigationTimeout(),
       waitUntil = ['load'],
+      referer,
     } = options;
     const normalizedWaitUntil = normalizeWaitUntil(waitUntil);
     const {navigationId} = await this._session.send('Page.navigate', {
       frameId: this._frameId,
+      referer,
       url,
     });
     if (!navigationId)

diff --git a/experimental/puppeteer-firefox/package.json b/experimental/puppeteer-firefox/package.json
@@ -9,7 +9,7 @@
     "node": ">=8.9.4"
   },
   "puppeteer": {
-    "firefox_revision": "32fc518d9228fd0115c0a4fd4bd341780bdba2fc"
+    "firefox_revision": "6186c850885f1fa486e9987b5119d2b4bcb53499"
   },
   "scripts": {
     "install": "node install.js",

diff --git a/test/navigation.spec.js b/test/navigation.spec.js
@@ -310,7 +310,7 @@ module.exports.addTests = function({testRunner, expect, Errors, CHROME}) {
       }
       expect(error.message).toContain(url);
     });
-    it_fails_ffox('should send referer', async({page, server}) => {
+    it('should send referer', async({page, server}) => {
       const [request1, request2] = await Promise.all([
         server.waitForRequest('/grid.html'),
         server.waitForRequest('/digits/1.png'),