Skip to content

Commit

Permalink
chore(docs): fix incorrect @returns on getter (#6175)
Browse files Browse the repository at this point in the history
On a getter function you don't use `@returns` (as that's just for
methods). Instead we can just add to the general remarks to explain what
the property is providing.
  • Loading branch information
jackfranklin committed Jul 8, 2020
1 parent 12ee70f commit 6ee7139
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
1 change: 1 addition & 0 deletions new-docs/puppeteer.puppeteer.devices.md
Expand Up @@ -12,6 +12,7 @@ get devices(): DevicesMap;

## Remarks

A list of devices to be used with `page.emulate(options)`<!-- -->. Actual list of devices can be found in [src/common/DeviceDescriptors.ts](https://github.com/puppeteer/puppeteer/blob/main/src/common/DeviceDescriptors.ts)<!-- -->.

## Example

Expand Down
2 changes: 1 addition & 1 deletion new-docs/puppeteer.puppeteer.errors.md
Expand Up @@ -14,7 +14,7 @@ get errors(): PuppeteerErrors;

Puppeteer methods might throw errors if they are unable to fulfill a request. For example, `page.waitForSelector(selector[, options])` might fail if the selector doesn't match any nodes during the given timeframe.

For certain types of errors Puppeteer uses specific error classes. These classes are available via `puppeteer.errors`
For certain types of errors Puppeteer uses specific error classes. These classes are available via `puppeteer.errors`<!-- -->.

## Example

Expand Down
6 changes: 4 additions & 2 deletions src/common/Puppeteer.ts
Expand Up @@ -202,6 +202,8 @@ export class Puppeteer {

/**
* @remarks
* A list of devices to be used with `page.emulate(options)`. Actual list of devices can be found in {@link https://github.com/puppeteer/puppeteer/blob/main/src/common/DeviceDescriptors.ts | src/common/DeviceDescriptors.ts}.
*
* @example
*
* ```js
Expand All @@ -218,7 +220,6 @@ export class Puppeteer {
* })();
* ```
*
* @returns a list of devices to be used with `page.emulate(options)`. Actual list of devices can be found in {@link https://github.com/puppeteer/puppeteer/blob/main/src/common/DeviceDescriptors.ts | src/common/DeviceDescriptors.ts}.
*/
get devices(): DevicesMap {
return devicesMap;
Expand All @@ -232,7 +233,8 @@ export class Puppeteer {
* the selector doesn't match any nodes during the given timeframe.
*
* For certain types of errors Puppeteer uses specific error classes.
* These classes are available via `puppeteer.errors`
* These classes are available via `puppeteer.errors`.
*
* @example
* An example of handling a timeout error:
* ```js
Expand Down

0 comments on commit 6ee7139

Please sign in to comment.