From 790c277f0ebdf2396b616d0ba823cd3416013787 Mon Sep 17 00:00:00 2001 From: Changhao Han Date: Fri, 10 Jul 2020 15:32:44 +0200 Subject: [PATCH] feat(chromium): roll Chromium to r768783 (#6201) * feat(chromium): roll Chromium to r768783 * fix: update unit test for crrev:2135046 * chore: update devtools-protocol revision Co-authored-by: Changhao Han --- package.json | 2 +- src/revisions.ts | 2 +- test/cookies.spec.ts | 4 +++- utils/check_availability.js | 3 ++- 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/package.json b/package.json index f0101afc7559f..c71db76f93f6a 100644 --- a/package.json +++ b/package.json @@ -45,7 +45,7 @@ "license": "Apache-2.0", "dependencies": { "debug": "^4.1.0", - "devtools-protocol": "0.0.754670", + "devtools-protocol": "0.0.767361", "extract-zip": "^2.0.0", "https-proxy-agent": "^4.0.0", "mime": "^2.0.3", diff --git a/src/revisions.ts b/src/revisions.ts index 9b307e9dca682..00166b52a2193 100644 --- a/src/revisions.ts +++ b/src/revisions.ts @@ -20,6 +20,6 @@ type Revisions = Readonly<{ }>; export const PUPPETEER_REVISIONS: Revisions = { - chromium: '756035', + chromium: '768783', firefox: 'latest', }; diff --git a/test/cookies.spec.ts b/test/cookies.spec.ts index e2c41f2b94722..ea840fe76ca2d 100644 --- a/test/cookies.spec.ts +++ b/test/cookies.spec.ts @@ -406,7 +406,9 @@ describe('Cookie specs', () => { expect(await page.evaluate('document.cookie')).toBe( 'localhost-cookie=best' ); - expect(await page.frames()[1].evaluate('document.cookie')).toBe(''); + expect(await page.frames()[1].evaluate('document.cookie')).toBe( + '127-cookie=worst' + ); expect(await page.cookies()).toEqual([ { diff --git a/utils/check_availability.js b/utils/check_availability.js index 1a5f2cab49d84..86e2f034ebcde 100755 --- a/utils/check_availability.js +++ b/utils/check_availability.js @@ -17,7 +17,8 @@ const assert = require('assert'); const https = require('https'); -const BrowserFetcher = require('../lib/BrowserFetcher').BrowserFetcher; +// run `npm run dev-install` if lib dir is missing +const BrowserFetcher = require('../lib/cjs/node/BrowserFetcher').BrowserFetcher; const SUPPORTER_PLATFORMS = ['linux', 'mac', 'win32', 'win64']; const fetchers = SUPPORTER_PLATFORMS.map(