fix: regression in --user-data-dir handling (#8060)

puppeteer · Feb 23, 2022 · 85decdc · 85decdc
1 parent 7e1794c
commit 85decdc
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 4 deletions.
diff --git a/src/node/Launcher.ts b/src/node/Launcher.ts
@@ -123,10 +123,6 @@ class ChromeLauncher implements ProductLauncher {
 
     if (userDataDirIndex !== -1) {
       userDataDir = chromeArguments[userDataDirIndex].split('=')[1];
-      if (!fs.existsSync(userDataDir)) {
-        throw new Error(`Chrome user data dir not found at '${userDataDir}'`);
-      }
-
       isTempUserDataDir = false;
     } else {
       userDataDir = await mkdtempAsync(

diff --git a/test/launcher.spec.ts b/test/launcher.spec.ts
@@ -276,6 +276,31 @@ describe('Launcher specs', function () {
         // This might throw. See https://github.com/puppeteer/puppeteer/issues/2778
         await rmAsync(userDataDir).catch(() => {});
       });
+      itChromeOnly('userDataDir argument with non-existent dir', async () => {
+        const { isChrome, puppeteer, defaultBrowserOptions } = getTestState();
+
+        const userDataDir = await mkdtempAsync(TMP_FOLDER);
+        await rmAsync(userDataDir);
+        const options = Object.assign({}, defaultBrowserOptions);
+        if (isChrome) {
+          options.args = [
+            ...(defaultBrowserOptions.args || []),
+            `--user-data-dir=${userDataDir}`,
+          ];
+        } else {
+          options.args = [
+            ...(defaultBrowserOptions.args || []),
+            '-profile',
+            userDataDir,
+          ];
+        }
+        const browser = await puppeteer.launch(options);
+        expect(fs.readdirSync(userDataDir).length).toBeGreaterThan(0);
+        await browser.close();
+        expect(fs.readdirSync(userDataDir).length).toBeGreaterThan(0);
+        // This might throw. See https://github.com/puppeteer/puppeteer/issues/2778
+        await rmAsync(userDataDir).catch(() => {});
+      });
       it('userDataDir option should restore state', async () => {
         const { server, puppeteer, defaultBrowserOptions } = getTestState();