From 8b712e7b642b58193437f26d4e104a9e412f388d Mon Sep 17 00:00:00 2001 From: Jan Scheffler Date: Wed, 27 Oct 2021 23:12:10 +0200 Subject: [PATCH] fix: setup husky properly (#7727) This change addresses breaking changes that happened in husky which, as a result, didn't run properly since the update. Closes #7726 --- .husky/commit-msg | 4 ++++ .husky/pre-comit | 4 ++++ .husky/pre-push | 4 ++++ package.json | 9 +-------- 4 files changed, 13 insertions(+), 8 deletions(-) create mode 100755 .husky/commit-msg create mode 100755 .husky/pre-comit create mode 100755 .husky/pre-push diff --git a/.husky/commit-msg b/.husky/commit-msg new file mode 100755 index 0000000000000..0bd658f49625b --- /dev/null +++ b/.husky/commit-msg @@ -0,0 +1,4 @@ +#!/bin/sh +. "$(dirname "$0")/_/husky.sh" + +npx --no-install commitlint --edit "$1" diff --git a/.husky/pre-comit b/.husky/pre-comit new file mode 100755 index 0000000000000..a8c5b0709784f --- /dev/null +++ b/.husky/pre-comit @@ -0,0 +1,4 @@ +#!/bin/sh +. "$(dirname "$0")/_/husky.sh" + +npm run eslint diff --git a/.husky/pre-push b/.husky/pre-push new file mode 100755 index 0000000000000..62434f4dcb242 --- /dev/null +++ b/.husky/pre-push @@ -0,0 +1,4 @@ +#!/bin/sh +. "$(dirname "$0")/_/husky.sh" + +npm run tsc && npm run eslint && npm run doc && npm run ensure-pinned-deps diff --git a/package.json b/package.json index 894f17e35884d..09b825b4c8225 100644 --- a/package.json +++ b/package.json @@ -17,7 +17,7 @@ "assert-unit-coverage": "cross-env COVERAGE=1 mocha --config mocha-config/coverage-tests.js", "funit": "cross-env PUPPETEER_PRODUCT=firefox npm run unit", "test": "npm run tsc && npm run lint --silent && npm run unit-with-coverage && npm run test-browser", - "prepare": "node typescript-if-required.js", + "prepare": "node typescript-if-required.js && husky install", "prepublishOnly": "npm run build", "dev-install": "npm run tsc && node install.js", "install": "node install.js", @@ -113,12 +113,5 @@ "text-diff": "1.0.1", "ts-node": "10.3.0", "typescript": "4.4.4" - }, - "husky": { - "hooks": { - "pre-commit": "npm run eslint", - "commit-msg": "commitlint --env HUSKY_GIT_PARAMS", - "pre-push": "npm run tsc && npm run eslint && npm run doc && npm run ensure-pinned-deps" - } } }