fix: multiple same request event listener (#8404)

puppeteer · May 30, 2022 · 9211015 · 9211015
1 parent d111d19
commit 9211015
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/src/common/Page.ts b/src/common/Page.ts
@@ -631,11 +631,13 @@ export class Page extends EventEmitter {
     handler: (event: PageEventObject[K]) => void
   ): EventEmitter {
     if (eventName === 'request') {
-      const wrap = (event: HTTPRequest) => {
-        event.enqueueInterceptAction(() =>
-          handler(event as PageEventObject[K])
-        );
-      };
+      const wrap =
+        this._handlerMap.get(handler) ||
+        ((event: HTTPRequest) => {
+          event.enqueueInterceptAction(() =>
+            handler(event as PageEventObject[K])
+          );
+        });
 
       this._handlerMap.set(handler, wrap);
 

diff --git a/test/page.spec.ts b/test/page.spec.ts
@@ -153,17 +153,21 @@ describe('Page', function () {
         }
       };
 
+      page.on('request', onResponse);
       page.on('request', onResponse);
       await page.goto(server.EMPTY_PAGE);
-      expect(handler.callCount).toBe(1);
+      expect(handler.callCount).toBe(2);
       page.off('request', onResponse);
       await page.goto(server.EMPTY_PAGE);
       // Still one because we removed the handler.
-      expect(handler.callCount).toBe(1);
+      expect(handler.callCount).toBe(3);
+      page.off('request', onResponse);
+      await page.goto(server.EMPTY_PAGE);
+      expect(handler.callCount).toBe(3);
       page.on('request', onResponse);
       await page.goto(server.EMPTY_PAGE);
       // Two now because we added the handler back.
-      expect(handler.callCount).toBe(2);
+      expect(handler.callCount).toBe(4);
     });
   });