From b6a6a9c8b6a9d99384318d3edda06e72ac50c4cd Mon Sep 17 00:00:00 2001 From: Alex Rudenko Date: Fri, 18 Mar 2022 12:54:38 +0100 Subject: [PATCH] chore: revert #7868 to use the size parameter for streaming PDF --- src/common/helper.ts | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/common/helper.ts b/src/common/helper.ts index 40c9ecd8c6d2d..215f182e4a829 100644 --- a/src/common/helper.ts +++ b/src/common/helper.ts @@ -360,15 +360,12 @@ async function getReadableFromProtocolStream( let eof = false; return new Readable({ - async read() { - // TODO: use the advised size parameter to read function once - // crbug.com/1290727 is resolved. - // Also, see https://github.com/puppeteer/puppeteer/pull/7868. + async read(size: number) { if (eof) { return null; } - const response = await client.send('IO.read', { handle }); + const response = await client.send('IO.read', { handle, size }); this.push(response.data, response.base64Encoded ? 'base64' : undefined); if (response.eof) { eof = true;