fix: ensure frame.url() includes the query string (#6398)

Co-authored-by: Mathias Bynens <mathias@qiwi.be>
puppeteer · Sep 8, 2020 · b6bbfd0 · b6bbfd0
1 parent 7b24e54
commit b6bbfd0
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/src/common/FrameManager.ts b/src/common/FrameManager.ts
@@ -1231,7 +1231,7 @@ export class Frame {
    */
   _navigated(framePayload: Protocol.Page.Frame): void {
     this._name = framePayload.name;
-    this._url = framePayload.url;
+    this._url = `${framePayload.url}${framePayload.urlFragment || ''}`;
   }
 
   /**

diff --git a/test/assets/frames/one-frame-url-fragment.html b/test/assets/frames/one-frame-url-fragment.html
@@ -0,0 +1 @@
+<iframe src='./frame.html&test=fragment'></iframe>
diff --git a/test/frame.spec.ts b/test/frame.spec.ts
@@ -256,5 +256,15 @@ describe('Frame specs', function () {
         expect(frame1).not.toBe(frame2);
       }
     );
+    it('should support url fragment', async () => {
+      const { page, server } = getTestState();
+
+      await page.goto(server.PREFIX + '/frames/one-frame-url-fragment.html');
+
+      expect(page.frames().length).toBe(2);
+      expect(page.frames()[1].url()).toBe(
+        server.PREFIX + '/frames/frame.html&test=fragment'
+      );
+    });
   });
 });